Fixed bug #961
authorSam Lantinga <slouken@libsdl.org>
Tue, 09 Mar 2010 06:07:48 +0000
changeset 4428 a3e71b957215
parent 4427 274743af0430
child 4429 1bceff8f008f
Fixed bug #961

Kalle Olavi Niemitalo 2010-02-28 09:15:50 PST

It seems the SDLK_LMETA and SDLK_RMETA constants have been removed from SDL
1.3. I grepped for them in the SDL source tree and these were the only hits:

./include/SDL_compat.h:230:#define SDLK_LSUPER SDLK_LMETA
./include/SDL_compat.h:231:#define SDLK_RSUPER SDLK_RMETA
./src/video/bwindow/SDL_BWin.h:194: keymap[0x66] = SDLK_LMETA;
./src/video/bwindow/SDL_BWin.h:195: keymap[0x67] = SDLK_RMETA;

I don't know how compatible SDL 1.3 is supposed to be with applications
designed for SDL 1.2. However, as you can see, SDL itself is still trying to
use the removed constants, and that is clearly a bug.

Because SDL_compat.h defines KMOD_LMETA as KMOD_LGUI, I suppose it should also
define SDLK_LMETA as SDLK_LGUI, and SDLK_RMETA likewise.
include/SDL_compat.h
--- a/include/SDL_compat.h	Fri Mar 05 15:43:46 2010 +0000
+++ b/include/SDL_compat.h	Tue Mar 09 06:07:48 2010 +0000
@@ -206,6 +206,8 @@
 #define SDLK_NUMLOCK SDLK_NUMLOCKCLEAR
 #define SDLK_SCROLLOCK SDLK_SCROLLLOCK
 #define SDLK_PRINT SDLK_PRINTSCREEN
+#define SDLK_LMETA SDLK_LGUI
+#define SDLK_RMETA SDLK_RGUI
 /*@}*//*Renamed keys*/
 
 /**