CREDITS.txt
author Sam Lantinga <slouken@libsdl.org>
Sat, 27 Jul 2013 03:20:09 -0700
changeset 7526 6c0f0280149c
parent 7238 daff4d9cedc6
child 7618 d381f183aa07
permissions -rw-r--r--
Fixed bug 1272 - Bogus numlock key up/down events being reported on MacOS X Vern Jensen The problem is that in certain situations I'm getting THREE keyUp/keyDown events when I push certain keys. In my event code I added: case SDL_KEYUP: printf("SDL KeyScanCode for KEYUP event: %d\n", event->key.keysym.scancode ); … and case SDL_KEYDOWN: printf("SDL KeyScanCode for KEYDOWN event: %d\n", event->key.keysym.scancode ); … The result of one test run where I push 2 keys and then release them is this: SDL KeyScanCode for KEYDOWN event: 92 // Pushed keypad 4 SDL KeyScanCode for KEYDOWN event: 83 // Pushed left shift SDL KeyScanCode for KEYUP event: 83 SDL KeyScanCode for KEYDOWN event: 225 SDL KeyScanCode for KEYUP event: 92 // Released keypad 4 SDL KeyScanCode for KEYDOWN event: 83 SDL KeyScanCode for KEYUP event: 83 SDL KeyScanCode for KEYUP event: 225 // Released left shift There *should* be only a total of 4 events above… 2 for each key being pushed, and 2 for each being released. But instead some bogus events for numlock being pushed/released are sent from SDL. These events did not occur. I did not push numlock. The value above for numlock is 83. Comments above show when I pushed each key. As you can see, when I push left shift, THREE events are instantly sent to my application, keyDown and then keyUp for numlock, and then the valid event for left shift (the key that was actually pushed). You could replace keypad 4 with pretty much any keyPad key and it'll still happen. You can also replace it with any arrow key and it'll happen. However, when trying it with normal letter keys on the main keyboard it didn't. It happens with other modifier keys too, not just left shift. The order in which the keys are pressed matter. For instance, if I do: 1) keypad 4 2) left shift 3) release left shift 4) release keypad 4 Then at step 2, I get the 3 events above (when there should be only one), but steps 3 and 4 work properly… I don't get extra keyUp/keyDown events for steps 3 or 4. Thereas if the order of steps 3 and 4 are reversed, I get the bogus extra events for numlock. Also, the problem can occur even when pushing just a single key by itself. If I push left shift, then keypad 4, then release left shift, then release keypad 4, then the following push of left shift will cause the bug. If I continue pushing and releasing left shift though, it won't happen again until I again involve keypad keys. --- Sam Lantinga According to the Apple documentation, NSNumericPadKeyMask is set for any arrow or numeric keypad event. Indeed this is what's happening. I verified that we get the correct events for the numlock key and the mod state gets set correcly, so it should be safe to remove this bogus code.


Simple DirectMedia Layer CREDITS
Thanks to everyone who made this possible, including:

* Cliff Matthews, for giving me a reason to start this project. :)
 -- Executor rocks!  *grin*

* The Linux Fund, C Magazine, Educational Technology Resources Inc.,
  Gareth Noyce, Jesse Pavel, Keith Kitchin, Jeremy Horvath, Thomas Nicholson,
  Hans-Peter Gygax, the Eternal Lands Development Team, Lars Brubaker,
  and Phoenix Kokido for financial contributions

* Edgar "bobbens" Simo for his force feedback API development during the
  Google Summer of Code 2008

* Aaron Wishnick for his work on audio resampling and pitch shifting during
  the Google Summer of Code 2008

* Holmes Futrell for port of SDL to the iPhone and iPod Touch during the
  Google Summer of Code 2008

* Szymon "Wilku" Wilczek for adding support for multiple mice and tablets
  during the Google Summer of Code 2008

* Marty Leisner, Andrew, Will, Edgar Simo, Donny Viszneki, Andrea Mazzoleni,
  Dmytro Bogovych, and Couriersud for helping find SDL 1.3 bugs in the great
  SDL Bug Hunt of January 2009!

* Donny Viszneki for helping fix SDL 1.3 bugs in the great SDL Bug Hunt of
  January 2009!

* Luke Benstead for OpenGL 3.0 support

* Gaëtan de Menten for writing the PHP and SQL behind the SDL website

* Tim Jones for the new look of the SDL website

* Ryan Gordon for helping everybody out and keeping the dream alive. :)

* Mattias Engdegård, for help with the Solaris port and lots of other help

* Eric Wing, Max Horn, and Darrell Walisser for unflagging work on the Mac OS X port

* David Carré, for the Pandora port

* Couriersud for the DirectFB driver

* Jon Atkins for SDL_image, SDL_mixer and SDL_net documentation

* Arne Claus, for the 2004 winning SDL logo,
  and Shandy Brown, Jac, Alex Lyman, Mikkel Gjoel, #Guy, Jonas Hartmann,
  Daniel Liljeberg,  Ronald Sowa, DocD, Pekka Jaervinen, Patrick Avella,
  Erkki Kontilla, Levon Gavalian, Hal Emerich, David Wiktorsson,
  S. Schury and F. Hufsky, Ciska de Ruyver, Shredweat, Tyler Montbriand,
  Martin Andersson, Merlyn Wysard, Fernando Ibanez, David Miller,
  Andre Bommele, lovesby.com, Francisco Camenforte Torres, and David Igreja
  for other logo entries.

* Bob Pendleton and David Olofson for being long time contributors to
  the SDL mailing list.

* Everybody at Loki Software, Inc. for their great contributions!

 And a big hand to everyone else who gave me appreciation, advice,
 and suggestions, especially the good folks on the SDL mailing list.

THANKS! :)

  -- Sam Lantinga			<slouken@libsdl.org>