Date: Tue, 05 Jul 2005 21:43:26 +1000
From: Sean Childs
Subject: [SDL] Compiling SDL 1.2.8 with the free Borland compiler
When compiling SDL 1.2.8 with the free Borland compiler, I received this
error (there is a similar error that occurs in
src\video\windx5\sdl_dx5events.c):
Error E2342 ..\..\src\video\windib\sdl_dibevents.c 189: Type mismatch in
parameter 'lpPrevWndFunc' (wanted 'int (__stdcall *)()', got 'long
(__stdcall *)(void *,unsigned int,unsigned int,long)') in function
DIB_HandleMessage
I checked the MSDN library at:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winui/
windowsuserinterface/windowing/windowprocedures/windowprocedurereference/wind
owprocedurefunctions/callwindowproc.asp
and it had this to say:
If STRICT is not defined, the lpPrevWndFunc parameter has the data type
FARPROC. The FARPROC type is declared as follows:
int (FAR WINAPI * FARPROC) ()
In C, the FARPROC declaration indicates a callback function that has an
unspecified parameter list. In C++, however, the empty parameter list in
the declaration indicates that a function has no parameters. This subtle
distinction can break careless code. Following is one way to handle this
situation:
#ifdef STRICT
WNDPROC MyWindowProcedure
#else
FARPROC MyWindowProcedure
#endif
...
lResult = CallWindowProc(MyWindowProcedure, ...)
--- a/src/video/windib/SDL_dibevents.c Tue Jan 31 14:59:43 2006 +0000
+++ b/src/video/windib/SDL_dibevents.c Tue Jan 31 15:30:42 2006 +0000
@@ -56,7 +56,12 @@
/* DJM: If the user setup the window for us, we want to save his window proc,
and give him a chance to handle some messages. */
-static WNDPROC userWindowProc = NULL;
+#ifdef STRICT
+#define WNDPROCTYPE WNDPROC
+#else
+#define WNDPROCTYPE FARPROC
+#endif
+static WNDPROCTYPE userWindowProc = NULL;
#ifdef _WIN32_WCE
@@ -427,7 +432,7 @@
/* DJM: we want all event's for the user specified
window to be handled by SDL.
*/
- userWindowProc = (WNDPROC)GetWindowLong(SDL_Window, GWL_WNDPROC);
+ userWindowProc = (WNDPROCTYPE)GetWindowLong(SDL_Window, GWL_WNDPROC);
SetWindowLong(SDL_Window, GWL_WNDPROC, (LONG)WinMessage);
} else {
SDL_Window = CreateWindow(SDL_Appname, SDL_Appname,
--- a/src/video/windx5/SDL_dx5events.c Tue Jan 31 14:59:43 2006 +0000
+++ b/src/video/windx5/SDL_dx5events.c Tue Jan 31 15:30:42 2006 +0000
@@ -66,7 +66,12 @@
/* DJM: If the user setup the window for us, we want to save his window proc,
and give him a chance to handle some messages. */
-static WNDPROC userWindowProc = NULL;
+#ifdef STRICT
+#define WNDPROCTYPE WNDPROC
+#else
+#define WNDPROCTYPE FARPROC
+#endif
+static WNDPROCTYPE userWindowProc = NULL;
static HWND GetTopLevelParent(HWND hWnd)
{
@@ -871,7 +876,7 @@
/* DJM: we want all event's for the user specified
window to be handled by SDL.
*/
- userWindowProc = (WNDPROC)GetWindowLong(SDL_Window, GWL_WNDPROC);
+ userWindowProc = (WNDPROCTYPE)GetWindowLong(SDL_Window, GWL_WNDPROC);
SetWindowLong(SDL_Window, GWL_WNDPROC, (LONG)WinMessage);
} else {
SDL_Window = CreateWindow(SDL_Appname, SDL_Appname,