Adam Strzelecki to SDL
authorSam Lantinga <slouken@libsdl.org>
Thu, 26 Nov 2009 05:55:57 +0000
changeset 3494 61d95a87c327
parent 3493 40b1f7cb2062
child 3495 1b22878e04d0
Adam Strzelecki to SDL Currently SDL uses GL_RGB for internalFormat when GL_YCBCR_MESA is passed as format for glTextImage2D when using Linux Mesa's OpenGL. However this is wrong and makes glTextImage2D fail with invalid argument error. GL_YCBCR_MESA should be also internalFormat (not GL_RGB) there and this is what can be found googling various source codes using GL_YCBCR_MESA.
src/video/SDL_renderer_gl.c
--- a/src/video/SDL_renderer_gl.c	Wed Nov 25 07:42:23 2009 +0000
+++ b/src/video/SDL_renderer_gl.c	Thu Nov 26 05:55:57 2009 +0000
@@ -707,7 +707,7 @@
             *type = GL_UNSIGNED_SHORT_8_8_REV_APPLE;
 #endif
         } else if (renderdata->GL_MESA_ycbcr_texture_supported) {
-            *internalFormat = GL_RGB;
+            *internalFormat = GL_YCBCR_MESA;
             *format = GL_YCBCR_MESA;
 #if SDL_BYTEORDER == SDL_LIL_ENDIAN
             *type = GL_UNSIGNED_SHORT_8_8_MESA;
@@ -732,7 +732,7 @@
             *type = GL_UNSIGNED_SHORT_8_8_APPLE;
 #endif
         } else if (renderdata->GL_MESA_ycbcr_texture_supported) {
-            *internalFormat = GL_RGB;
+            *internalFormat = GL_YCBCR_MESA;
             *format = GL_YCBCR_MESA;
 #if SDL_BYTEORDER == SDL_LIL_ENDIAN
             *type = GL_UNSIGNED_SHORT_8_8_REV_MESA;