Date: Mon, 15 May 2006 17:18:34 +0300
From: Vassilis Virvilis
Subject: Re: [SDL] SDL + fbcon = weird colors (resolved)
> I am getting weird colors in 16/32 bpp in an VIA custom
> board with savagefb and in qemu (cirrusfb).
Ok looks that nowadays if you follow compiler warnings closely
all bugs will be resolved by you. This one was that a non void
function (do_mmap) was not returning anything.
I also silenced a warning since I was in janitor mode.
--- a/src/video/fbcon/SDL_fbvideo.c Mon May 15 12:22:58 2006 +0000
+++ b/src/video/fbcon/SDL_fbvideo.c Tue May 16 03:58:08 2006 +0000
@@ -160,13 +160,14 @@
ret = mmap(start, length, prot,
(flags & ~MAP_SHARED) | MAP_PRIVATE, fd, offset);
}
+ return ret;
}
/* FB driver bootstrap functions */
static int FB_Available(void)
{
- int console;
+ int console = -1;
/* Added check for /fb/0 (devfs) */
/* but - use environment variable first... if it fails, still check defaults */
int idx = 0;