Fixed typo in mask comparison SDL-1.2
authorSam Lantinga <slouken@libsdl.org>
Tue, 10 Jan 2012 22:52:17 -0500
branchSDL-1.2
changeset 6209 beb988469d26
parent 6206 ceb6db0058f1
child 6215 a84cb42bce7f
Fixed typo in mask comparison Bl0ckeduser I downloaded the SDL 1.2.15 prerelease and compiled it (under Mac OS Classic). All the tests worked without issues, but the compiler gave this warning [formatting edited for email format]: } else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) { ":src:video:SDL_video.c"; line 990 #Warning 2: possible unintended assignment I discussed this with another programmer and we came to the conclusion that this is probably a typo. I have checked the latest mercurial sources, and the possible typo is still there. Bl0ckeduser
src/video/SDL_video.c
--- a/src/video/SDL_video.c	Tue Jan 10 21:12:45 2012 +0100
+++ b/src/video/SDL_video.c	Tue Jan 10 22:52:17 2012 -0500
@@ -987,7 +987,7 @@
 		if ( (vf->Rmask == 0xff) && (vf->Bmask == 0xff0000) ) {
 			rmask = 0xff;
 			bmask = 0xff0000;
-		} else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) {
+		} else if ( vf->Rmask == 0xFF00 && (vf->Bmask == 0xFF000000) ) {
 			amask = 0x000000FF;
 			rmask = 0x0000FF00;
 			gmask = 0x00FF0000;