Gregory McLean pointed out that pthreads are needed; start to mark ou…

…t the code to remove it in the future and just use fork().
icculus · Jul 14, 2004 · 98eb02c · 98eb02c
1 parent 33f6cd8
commit 98eb02c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/Makefile b/Makefile
@@ -8,6 +8,7 @@ SRCDIR := .
 
 platform := macosx
 use_zlib := true
+use_pthread := false
 
 ifeq ($(strip $(platform)),macosx)
 PLATFORMDEF := -DPLATFORM_UNIX -DPLATFORM_MACOSX
@@ -23,6 +24,9 @@ endif
 ifeq ($(strip $(platform)),unix)
 PLATFORMDEF := -DPLATFORM_UNIX
 PLATFORMSRCS := platform_unix.c ui_stdio.c
+
+# !!! FIXME: This is forced on for now.
+use_pthread := true
 endif
 
 CFLAGS := $(PLATFORMDEF) -Wall -g -fsigned-char -fno-omit-frame-pointer -O0
@@ -32,6 +36,11 @@ ifeq ($(strip $(use_zlib)),true)
   LDFLAGS += -lz
 endif
 
+ifeq ($(strip $(use_pthread)),true)
+  LDFLAGS += -lpthread
+  CFLAGS += -DUSE_PTHREAD=1
+endif
+
 MOJOPATCHSRCS := mojopatch.c md5.c $(PLATFORMSRCS)
 OBJS1 := $(MOJOPATCHSRCS:.c=.o)
 OBJS2 := $(OBJS1:.cpp=.o)

diff --git a/platform_unix.c b/platform_unix.c
@@ -10,7 +10,15 @@
 #include <sys/param.h>
 #include <errno.h>
 #include <assert.h>
+
+/* !!! FIXME: Why aren't we using fork(), anyhow? */
+#if !USE_PTHREAD
+#error not implemented yet.
+#endif
+
+#if USE_PTHREAD
 #include <pthread.h>
+#endif
 
 #include "platform.h"
 #include "ui.h"
@@ -512,6 +520,10 @@ static void *spawn_thread(void *arg)
 
 int spawn_xdelta(const char *cmdline)
 {
+#if !USE_PTHREAD
+    _fatal("No pthread support!");
+    return(0);
+#else
     pthread_t thr;
     void *rc;
     const char *binname = "xdelta";
@@ -532,6 +544,7 @@ int spawn_xdelta(const char *cmdline)
 
     pthread_join(thr, &rc);
     return(1);  /* !!! FIXME    *((int *) rc) == 0 ); */
+#endif
 } /* spawn_xdelta */