From 959f0e9f51306ac50f98d82d3c00ca6cbf77a906 Mon Sep 17 00:00:00 2001 From: "Ryan C. Gordon" Date: Wed, 5 Aug 2009 18:39:52 -0400 Subject: [PATCH] Added some FIXMEs. --- mojoshader.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/mojoshader.c b/mojoshader.c index 4a0f14ad..475b3c27 100644 --- a/mojoshader.c +++ b/mojoshader.c @@ -6918,6 +6918,15 @@ static char *alloc_varname(Context *ctx, const RegisterList *reg) } // alloc_varname +// !!! FIXME: this code is sort of hard to follow: +// !!! FIXME: "var->used" only applies to arrays (at the moment, at least, +// !!! FIXME: but this might be buggy at a later time?), and this code +// !!! FIXME: relies on that. +// !!! FIXME: "variables" means "things we found in a CTAB" but it's not +// !!! FIXME: all registers, etc. +// !!! FIXME: "const_array" means an array for d3d "const" registers (c0, c1, +// !!! FIXME: etc), but not a constant array, although they _can_ be. +// !!! FIXME: It's just a mess. :/ static MOJOSHADER_uniform *build_uniforms(Context *ctx) { const size_t len = sizeof (MOJOSHADER_uniform) * ctx->uniform_count; @@ -6956,6 +6965,7 @@ static MOJOSHADER_uniform *build_uniforms(Context *ctx) { int skip = 0; + // !!! FIXME: does this fail if written > ctx->uniform_count? if (item == NULL) { fail(ctx, "BUG: mismatched uniform list and count");