spv_output_location for COLOR0+ pixel shader output

icculus · Jan 10, 2020 · f4070d6 · f4070d6
1 parent 53ee697
commit f4070d6
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/profiles/mojoshader_profile_spirv.c b/profiles/mojoshader_profile_spirv.c
@@ -1531,7 +1531,15 @@ static void spv_link_ps_attributes(Context *ctx, uint32 id, RegisterType regtype
     switch (regtype)
     {
         case REG_TYPE_COLOROUT:
-            // nothing to do for color, OpenGL should hook it up automatically??
+            // Per KHR_glsl_shader:
+            // The fragment-stage built-in gl_FragColor, which implies a broadcast to all
+            // outputs, is not present in SPIR-V. Shaders where writing to gl_FragColor
+            // is allowed can still write to it, but it only means to write to an output:
+            // - of the same type as gl_FragColor
+            // - decorated with location 0
+            // - not decorated as a built-in variable.
+            // There is no implicit broadcast.
+            spv_output_location(ctx, id, 0 + index);
             break;
         case REG_TYPE_INPUT: // v# (MOJOSHADER_USAGE_COLOR aka `oC#` in vertex shader)
             switch (usage)