Added some FIXMEs.
authorRyan C. Gordon <icculus@icculus.org>
Wed, 05 Aug 2009 18:39:52 -0400
changeset 758 f25ef1cca5e2
parent 757 29b25b4c7aeb
child 759 3b891dbe951a
Added some FIXMEs.
mojoshader.c
--- a/mojoshader.c	Sun Jul 19 16:23:39 2009 -0400
+++ b/mojoshader.c	Wed Aug 05 18:39:52 2009 -0400
@@ -6918,6 +6918,15 @@
 } // alloc_varname
 
 
+// !!! FIXME: this code is sort of hard to follow:
+// !!! FIXME:  "var->used" only applies to arrays (at the moment, at least,
+// !!! FIXME:  but this might be buggy at a later time?), and this code
+// !!! FIXME:  relies on that.
+// !!! FIXME: "variables" means "things we found in a CTAB" but it's not
+// !!! FIXME:  all registers, etc.
+// !!! FIXME: "const_array" means an array for d3d "const" registers (c0, c1,
+// !!! FIXME:  etc), but not a constant array, although they _can_ be.
+// !!! FIXME: It's just a mess.  :/
 static MOJOSHADER_uniform *build_uniforms(Context *ctx)
 {
     const size_t len = sizeof (MOJOSHADER_uniform) * ctx->uniform_count;
@@ -6956,6 +6965,7 @@
         {
             int skip = 0;
 
+            // !!! FIXME: does this fail if written > ctx->uniform_count?
             if (item == NULL)
             {
                 fail(ctx, "BUG: mismatched uniform list and count");