Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fixed PHYSFS_openAppend() on Unix.
Apparently O_APPEND doesn't behave like I thought it did...all these years.  :/
  • Loading branch information
icculus committed Apr 3, 2008
1 parent 1b042d1 commit 6174996
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.txt
Expand Up @@ -2,6 +2,7 @@
* CHANGELOG.
*/

04032008 - Fixed PHYSFS_openAppend() to work as documented on Unix.
03122008 - Fixed aliasing bug in Windows platform layer (thanks, Dennis!).
03102008 - Changed some text files from ISO-8859-1 to UTF-8. Replaced all the
translations with UTF-8 encoded equivalents.
Expand Down
13 changes: 13 additions & 0 deletions platform/posix.c
Expand Up @@ -236,13 +236,26 @@ int __PHYSFS_platformMkDir(const char *path)

static void *doOpen(const char *filename, int mode)
{
const int appending = (mode & O_APPEND);
int fd;
int *retval;
errno = 0;

/* O_APPEND doesn't actually behave as we'd like. */
mode &= ~O_APPEND;

fd = open(filename, mode, S_IRUSR | S_IWUSR);
BAIL_IF_MACRO(fd < 0, strerror(errno), NULL);

if (appending)
{
if (lseek(fd, 0, SEEK_END) < 0)
{
close(fd);
BAIL_MACRO(strerror(errno), NULL);
} /* if */
} /* if */

retval = (int *) allocator.Malloc(sizeof (int));
if (retval == NULL)
{
Expand Down

0 comments on commit 6174996

Please sign in to comment.