Only flush file handles on close if they were opened for writing.

(transplanted from 89e1b79e10c6e9faf9e4c06dc357dee5ef2c7d4f)
icculus · Mar 18, 2019 · fa34bb4 · fa34bb4
1 parent 9a825fc
commit fa34bb4
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/physfs.c b/src/physfs.c
@@ -2678,12 +2678,15 @@ static int closeHandleInOpenList(FileHandle **list, FileHandle *handle)
             PHYSFS_uint8 *tmp = handle->buffer;
 
             /* send our buffer to io... */
-            if (!PHYSFS_flush((PHYSFS_File *) handle))
-                return -1;
+            if (!handle->forReading)
+            {
+                if (!PHYSFS_flush((PHYSFS_File *) handle))
+                    return -1;
 
-            /* ...then have io send it to the disk... */
-            else if (io->flush && !io->flush(io))
-                return -1;
+                /* ...then have io send it to the disk... */
+                else if (io->flush && !io->flush(io))
+                    return -1;
+            } /* if */
 
             /* ...then close the underlying file. */
             io->destroy(io);