Fixed mishandling of an allocation failure in PHYSFS_openRead().

(Static analysis caught this one! Thanks clang!)
icculus · May 12, 2020 · 235e31c · 235e31c
1 parent 291cad0
commit 235e31c
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/src/physfs.c b/src/physfs.c
@@ -2731,13 +2731,15 @@ PHYSFS_File *PHYSFS_openRead(const char *_fname)
                 io->destroy(io);
                 PHYSFS_setErrorCode(PHYSFS_ERR_OUT_OF_MEMORY);
             } /* if */
-
-            memset(fh, '\0', sizeof (FileHandle));
-            fh->io = io;
-            fh->forReading = 1;
-            fh->dirHandle = i;
-            fh->next = openReadList;
-            openReadList = fh;
+            else
+            {
+                memset(fh, '\0', sizeof (FileHandle));
+                fh->io = io;
+                fh->forReading = 1;
+                fh->dirHandle = i;
+                fh->next = openReadList;
+                openReadList = fh;
+            } /* else */
         } /* if */
     } /* if */