Thu, 15 Apr 2010 21:27:32 -0700 Fixed bug 984
Sam Lantinga <slouken@libsdl.org> [Thu, 15 Apr 2010 21:27:32 -0700] rev 4433
Fixed bug 984 SDL_CreateTexture allows the creation of textures of size 0, which can lead to div by 0 errors
Tue, 13 Apr 2010 22:01:14 -0700 Fixed bug 944
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Apr 2010 22:01:14 -0700] rev 4432
Fixed bug 944 Tatu Kilappa 2010-02-11 12:13:20 PST When compiling with -Wconversion, gcc complains about a cast in SDL_endian.h that might change the result as we are casting from an int into an Uint16. This is of course not visible unless we are on a non-x86 platform where the assembler is not available. While it's not really an error, the warning is really annoying. To fix, change SDL_endian.h line 87 to: return(Uint16)((x<<8)|(x>>8)); Thank you.
Tue, 13 Apr 2010 21:46:10 -0700 Fixed bug 944 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Apr 2010 21:46:10 -0700] rev 4431
Fixed bug 944 Tatu Kilappa 2010-02-11 12:13:20 PST When compiling with -Wconversion, gcc complains about a cast in SDL_endian.h that might change the result as we are casting from an int into an Uint16. This is of course not visible unless we are on a non-x86 platform where the assembler is not available. While it's not really an error, the warning is really annoying. To fix, change SDL_endian.h line 87 to: return(Uint16)((x<<8)|(x>>8)); Thank you.
Tue, 13 Apr 2010 21:24:55 -0700 CVS is so last decade... SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Apr 2010 21:24:55 -0700] rev 4430
CVS is so last decade...
Thu, 25 Mar 2010 01:08:26 -0700 General improvements for user custom event registration
Sam Lantinga <slouken@libsdl.org> [Thu, 25 Mar 2010 01:08:26 -0700] rev 4429
General improvements for user custom event registration * Switched event type to enum (int32) * Switched polling by mask to polling by type range * Added SDL_RegisterEvents() to allow dynamic user event registration * Spread events out to allow inserting new related events without breaking binary compatibility * Added padding to event structures so they're the same size regardless of 32-bit compiler structure packing settings * Split SDL_HasEvent() to SDL_HasEvent() for a single event and SDL_HasEvents() for a range of events * Added SDL_GetEventState() as a shortcut for SDL_EventState(X, SDL_QUERY) * Added SDL_FlushEvent() and SDL_FlushEvents() to clear events from the event queue
Wed, 10 Mar 2010 15:07:20 +0000 Fixed bug #968
Sam Lantinga <slouken@libsdl.org> [Wed, 10 Mar 2010 15:07:20 +0000] rev 4428
Fixed bug #968 Andrey 2010-03-07 07:57:14 PST mingw32ce-build small fix
Wed, 10 Mar 2010 15:04:13 +0000 Fixed bug #943 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Wed, 10 Mar 2010 15:04:13 +0000] rev 4427
Fixed bug #943 Ozkan Sezer 2010-02-06 12:31:06 PST Hi: Here are some small fixes for compiling SDL against mingw-w64. (see http://mingw-w64.sourceforge.net/ . Despite the name, it supports both win32 and win64.) Two patches, one for SDL-1.2 and one for SDL-1.3 attached. src/audio/windx5/directx.h and src/video/windx5/directx.h (both SDL-1.2 and SDL-1.3.) I get compilation errors about some union not having a member named u1 and alike, because of other system headers being included before this one and them already defining DUMMYUNIONNAME and stuff. This header probably assumes that those stuff are defined in windef.h, but mingw-w64 headers define them in _mingw.h. Easily fixed by moving NONAMELESSUNION definition to the top of the file. SDL_dx5yuv.c (SDL-1.2-only) also needs to include the header before SDL_video.h to avoid the same problem. src/thread/win32/SDL_systhread.c (both SDL-1.2 and SDL-1.3.) : The __GNUC__ case for pfnSDL_CurrentBeginThread is 32-bit centric because _beginthreadex returns uintptr_t, not unsigned long which is 32 bits in win64. Changing the return type to uintptr_t fixes it. Hope these are useful. Thanks.
Wed, 10 Mar 2010 15:02:58 +0000 Fixed bug #943
Sam Lantinga <slouken@libsdl.org> [Wed, 10 Mar 2010 15:02:58 +0000] rev 4426
Fixed bug #943 Ozkan Sezer 2010-02-06 12:31:06 PST Hi: Here are some small fixes for compiling SDL against mingw-w64. (see http://mingw-w64.sourceforge.net/ . Despite the name, it supports both win32 and win64.) src/audio/windx5/directx.h and src/video/windx5/directx.h (both SDL-1.2 and SDL-1.3.) I get compilation errors about some union not having a member named u1 and alike, because of other system headers being included before this one and them already defining DUMMYUNIONNAME and stuff. This header probably assumes that those stuff are defined in windef.h, but mingw-w64 headers define them in _mingw.h. Easily fixed by moving NONAMELESSUNION definition to the top of the file. src/thread/win32/SDL_systhread.c (both SDL-1.2 and SDL-1.3.) : The __GNUC__ case for pfnSDL_CurrentBeginThread is 32-bit centric because _beginthreadex returns uintptr_t, not unsigned long which is 32 bits in win64. Changing the return type to uintptr_t fixes it. video/SDL_blit.h (and configure.in) (SDL-1.3-only) : MinGW-w64 uses msvcrt version of _aligned_malloc and _aligned_free and they are defined in intrin.h (similar to VC). Adding proper ifdefs fixes it. (Notes about macros to check: __MINGW32__ is defined for both mingw.org and for mingw-w64 for both win32 and win64, __MINGW64__ is only defined for _WIN64, so __MINGW64__ can't be used to detect mingw-w64: including _mingw.h and then checking for __MINGW64_VERSION_MAJOR does the trick.) SDL_win32video.h (SDL-1.3-only) : Tweaked the VINWER definition and location in order to avoid multiple redefinition warnings. Hope these are useful. Thanks.
Tue, 09 Mar 2010 06:07:48 +0000 Fixed bug #961
Sam Lantinga <slouken@libsdl.org> [Tue, 09 Mar 2010 06:07:48 +0000] rev 4425
Fixed bug #961 Kalle Olavi Niemitalo 2010-02-28 09:15:50 PST It seems the SDLK_LMETA and SDLK_RMETA constants have been removed from SDL 1.3. I grepped for them in the SDL source tree and these were the only hits: ./include/SDL_compat.h:230:#define SDLK_LSUPER SDLK_LMETA ./include/SDL_compat.h:231:#define SDLK_RSUPER SDLK_RMETA ./src/video/bwindow/SDL_BWin.h:194: keymap[0x66] = SDLK_LMETA; ./src/video/bwindow/SDL_BWin.h:195: keymap[0x67] = SDLK_RMETA; I don't know how compatible SDL 1.3 is supposed to be with applications designed for SDL 1.2. However, as you can see, SDL itself is still trying to use the removed constants, and that is clearly a bug. Because SDL_compat.h defines KMOD_LMETA as KMOD_LGUI, I suppose it should also define SDLK_LMETA as SDLK_LGUI, and SDLK_RMETA likewise.
Fri, 05 Mar 2010 15:43:46 +0000 Removed reference to compatibility function
Sam Lantinga <slouken@libsdl.org> [Fri, 05 Mar 2010 15:43:46 +0000] rev 4424
Removed reference to compatibility function
Sun, 28 Feb 2010 09:23:23 +0000 Disable error checks for reset actuators and set autocenter.
Edgar Simo <bobbens@gmail.com> [Sun, 28 Feb 2010 09:23:23 +0000] rev 4423
Disable error checks for reset actuators and set autocenter. Reset actuators and set autocenter might not actually be supported on all implementations. We'll just disable error checking since they aren't critical to neither opening the joystick nor the haptic subsystem.
Sun, 28 Feb 2010 23:45:02 -0800 Replaced README.SVN with Mercurial information, for 1.2 branch. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 23:45:02 -0800] rev 4422
Replaced README.SVN with Mercurial information, for 1.2 branch.
Sun, 28 Feb 2010 03:23:07 -0500 Changed the Subversion README to Mercurial.
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 03:23:07 -0500] rev 4421
Changed the Subversion README to Mercurial.
Sun, 28 Feb 2010 02:19:04 -0500 Added .hgignore file for 1.2 branch. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 02:19:04 -0500] rev 4420
Added .hgignore file for 1.2 branch.
Sun, 28 Feb 2010 02:07:40 -0500 Changed revision details to be a string (an hg changeset) instead of an int.
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 02:07:40 -0500] rev 4419
Changed revision details to be a string (an hg changeset) instead of an int.
Sun, 28 Feb 2010 02:06:47 -0500 Made an .hgignore to mostly match old svn:ignore properties.
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 02:06:47 -0500] rev 4418
Made an .hgignore to mostly match old svn:ignore properties.
Sun, 28 Feb 2010 00:31:38 -0500 Readded Xcode.tar.gz to the Mercurial repository. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 00:31:38 -0500] rev 4417
Readded Xcode.tar.gz to the Mercurial repository. (This was stripped from previous revisions to make the repo smaller.)
Sun, 28 Feb 2010 00:21:37 -0500 Closing obsolete SDL-1.3 named branch SDL-1.3
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 00:21:37 -0500] rev 4416
Closing obsolete SDL-1.3 named branch
Sun, 28 Feb 2010 00:21:36 -0500 Closing obsolete SDL-ryan-multiple-audio-device named branch SDL-ryan-multiple-audio-device
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 00:21:36 -0500] rev 4415
Closing obsolete SDL-ryan-multiple-audio-device named branch
Sun, 28 Feb 2010 00:21:35 -0500 Closing obsolete SDL-1.2-olpc named branch SDL-1.2-olpc
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 00:21:35 -0500] rev 4414
Closing obsolete SDL-1.2-olpc named branch
Sun, 28 Feb 2010 00:21:33 -0500 Closing obsolete gsoc2008_audio_resampling named branch gsoc2008_audio_resampling
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 00:21:33 -0500] rev 4413
Closing obsolete gsoc2008_audio_resampling named branch
Sun, 28 Feb 2010 00:21:32 -0500 Closing obsolete gsoc2008_manymouse named branch gsoc2008_manymouse
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 00:21:32 -0500] rev 4412
Closing obsolete gsoc2008_manymouse named branch
Sun, 28 Feb 2010 00:21:32 -0500 Closing obsolete gsoc2008_iphone named branch gsoc2008_iphone
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 00:21:32 -0500] rev 4411
Closing obsolete gsoc2008_iphone named branch
Sun, 28 Feb 2010 00:21:31 -0500 Closing obsolete gsoc2008_force_feedback named branch gsoc2008_force_feedback
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 00:21:31 -0500] rev 4410
Closing obsolete gsoc2008_force_feedback named branch
Sun, 28 Feb 2010 00:21:30 -0500 Closing obsolete gsoc2008_nds named branch gsoc2008_nds
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 00:21:30 -0500] rev 4409
Closing obsolete gsoc2008_nds named branch
Sun, 28 Feb 2010 00:21:28 -0500 Closing obsolete gsoc2009_unit_tests named branch gsoc2009_unit_tests
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 00:21:28 -0500] rev 4408
Closing obsolete gsoc2009_unit_tests named branch
Sun, 28 Feb 2010 00:21:27 -0500 Closing obsolete gsoc2009_IME named branch gsoc2009_IME
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 00:21:27 -0500] rev 4407
Closing obsolete gsoc2009_IME named branch
Sun, 28 Feb 2010 00:21:26 -0500 Closing obsolete gsoc2009_ps3 named branch gsoc2009_ps3
Ryan C. Gordon <icculus@icculus.org> [Sun, 28 Feb 2010 00:21:26 -0500] rev 4406
Closing obsolete gsoc2009_ps3 named branch
Sun, 28 Feb 2010 09:56:32 +0000 update tags
convert-repo [Sun, 28 Feb 2010 09:56:32 +0000] rev 4405
update tags
Thu, 19 Apr 2007 07:12:30 +0000 First shot at GTK+ video target for the OLPC laptops. Seriously incomplete, SDL-1.2-olpc
Ryan C. Gordon <icculus@icculus.org> [Thu, 19 Apr 2007 07:12:30 +0000] rev 4404
First shot at GTK+ video target for the OLPC laptops. Seriously incomplete, but it's enough to get some bits to a window...
Thu, 19 Apr 2007 07:10:05 +0000 Branching for some One Laptop Per Child experiments. SDL-1.2-olpc
Ryan C. Gordon <icculus@icculus.org> [Thu, 19 Apr 2007 07:10:05 +0000] rev 4403
Branching for some One Laptop Per Child experiments.
Fri, 12 Feb 2010 16:59:34 +0000 Fixed channel swizzling for ALSA target with 6-channel output. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Fri, 12 Feb 2010 16:59:34 +0000] rev 4402
Fixed channel swizzling for ALSA target with 6-channel output. Fixes Bugzilla #942.
Fri, 05 Feb 2010 19:20:49 +0000 Fixed uninitialized variable in FreeBSD joystick. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Fri, 05 Feb 2010 19:20:49 +0000] rev 4401
Fixed uninitialized variable in FreeBSD joystick. Patch by Marcus von Appen.
Sun, 24 Jan 2010 20:08:14 +0000 PulseAudio: get the window title for the context name if it wasn't set already. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Sun, 24 Jan 2010 20:08:14 +0000] rev 4400
PulseAudio: get the window title for the context name if it wasn't set already. Will still fall back to get_progname() if it can't figure out the title.
Sun, 24 Jan 2010 17:54:57 +0000 Patched to compile on Visual C++. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Sun, 24 Jan 2010 17:54:57 +0000] rev 4399
Patched to compile on Visual C++.
Sun, 24 Jan 2010 08:35:09 +0000 1.2: let PulseAudio hook into SDL_WM_SetCaption(). SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Sun, 24 Jan 2010 08:35:09 +0000] rev 4398
1.2: let PulseAudio hook into SDL_WM_SetCaption(). This lets Pulse's system-wide list of currently playing sources have accurate names for SDL applications. DO NOT MERGE WITH 1.3...we'll design a more formal API there.
Sun, 17 Jan 2010 05:19:32 +0000 Reverted accidental commit. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Sun, 17 Jan 2010 05:19:32 +0000] rev 4397
Reverted accidental commit.
Sun, 17 Jan 2010 05:17:59 +0000 1.2 pulseaudio: make some function pointers static. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Sun, 17 Jan 2010 05:17:59 +0000] rev 4396
1.2 pulseaudio: make some function pointers static.
Wed, 06 Jan 2010 06:41:41 +0000 Call SDL_OutOfMemory() if SDL_malloc() fails. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Wed, 06 Jan 2010 06:41:41 +0000] rev 4395
Call SDL_OutOfMemory() if SDL_malloc() fails.
Thu, 17 Dec 2009 14:33:00 +0000 Merged SDL 1.3 revision 5424, fixing a crash in the joystick code on recent kernels. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Thu, 17 Dec 2009 14:33:00 +0000] rev 4394
Merged SDL 1.3 revision 5424, fixing a crash in the joystick code on recent kernels.
Mon, 14 Dec 2009 22:41:31 +0000 Fixed bug #901 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 14 Dec 2009 22:41:31 +0000] rev 4393
Fixed bug #901 Tim Angus 2009-12-11 11:45:46 PST Disable mouse event generation when state is not SDL_APPMOUSEFOCUS If a Windows SDL application is minimised by using alt-tab, SDL_APPMOUSEFOCUS is lost as part of the minimisation. Unfortunately, the directx driver doesn't pay any attention to this state when generating mouse button events, so clicking on the Desktop can cause mouse clicks in the SDL application, while it's still minimised. The attached patch fixes this. It looks much more complicated than it actually is due to indentation; here it is ignoring whitespace: tma@abraxas:~/sources/SDL-1.2-svn$ svn diff -x -b Index: src/video/windx5/SDL_dx5events.c =================================================================== --- src/video/windx5/SDL_dx5events.c (revision 5376) +++ src/video/windx5/SDL_dx5events.c (working copy) @@ -374,10 +374,9 @@ if ( !(SDL_GetAppState() & SDL_APPMOUSEFOCUS) ) { mouse_lost = 1; ClipCursor(NULL); - } - + } else { /* If the mouse was lost, regain some sense of mouse state */ - if ( mouse_lost && (SDL_GetAppState() & SDL_APPMOUSEFOCUS) ) { + if ( mouse_lost ) { POINT mouse_pos; Uint8 old_state; Uint8 new_state; @@ -548,6 +547,7 @@ if ( xrel || yrel ) { post_mouse_motion(1, xrel, yrel); } + } } /* The main Win32 event handler */
Fri, 11 Dec 2009 15:31:37 +0000 Fixed bug #898 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Fri, 11 Dec 2009 15:31:37 +0000] rev 4392
Fixed bug #898 Jeremiah Morris 2009-12-09 16:07:17 PST No-op GlobalToLocal translations in fullscreen mode On my MacBook Pro running 10.6, I noticed a small upward bias on mouse movement in a fullscreen SDL application. The app uses WarpCursor and GetMouseState in a loop to measure relative movement. I tracked it down to NSWindow's convertBaseToScreen: routine, which added a 2-pixel offset on the Y coordinate instead of the expected (+0,+0) translation. In fullscreen mode, QZ_PrivateWarpCursor() does not translate the desired position through QZ_PrivateGlobalToLocal() before passing it to the Core Graphics system. However, QZ_GetMouseLocation() does call the reverse QZ_PrivateLocalToGlobal() even in fullscreen mode. This asymmetry caused problems each time the mouse was moved.
Fri, 11 Dec 2009 15:24:53 +0000 Fixed bug #849 some more: SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Fri, 11 Dec 2009 15:24:53 +0000] rev 4391
Fixed bug #849 some more: Tim Angus 2009-11-26 14:41:04 PST Fix to the cursor not being responsive when the app doesn't have SDL_APPINPUTFOCUS The problems with the directx driver are similar to the ones I introduced in the windib driver with r4478. Basically if the application did not have focus, the mouse position is not updated. It's not really that the mouse cursor was invisible, it's that it is stuck underneath another window where you can't see it. This behaviour predates my r4478 changes and is the reason I unwittingly broke the windib driver as I had been replicating the way the directx driver deals with focus. Prior to r4478 the directx driver could not be used in windowed mode, so the broken focusing would not have actually been observable. Anyway, the attached patch makes the directx driver behaves like the windib driver in terms of focus. Time for 1.2.15? ;) I've added an additional change of moving the calls to WIN_GrabInput that are made on WM_ACTIVATE messages so that they only occur when the state is SDL_APPINPUTFOCUS. When a fullscreen application is minimised using alt-tab, it still receives WM_ACTIVATE messages when other applications are selected. If WIN_GrabInput is called when the SDL application doesn't have input focus, bad things happen; it shouldn't be being called at all. I've also added a line to make sure that SDL_APPMOUSEFOCUS state is dropped when the application is minimised following an alt-tab.
Fri, 11 Dec 2009 15:14:13 +0000 Fixed bug #895 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Fri, 11 Dec 2009 15:14:13 +0000] rev 4390
Fixed bug #895 Markus Rothe 2009-12-07 09:32:46 PST Check if libspe2 is available Building on PowerPC64 results in: [...] In file included from ./src/video/ps3/SDL_ps3events_c.h:33, from ./src/video/ps3/SDL_ps3video.c:32: ./src/video/ps3/SDL_ps3video.h:34:21: error: libspe2.h: No such file or directory In file included from ./src/video/ps3/SDL_ps3events_c.h:33, from ./src/video/ps3/SDL_ps3video.c:32: ./src/video/ps3/SDL_ps3video.h:75: error: expected specifier-qualifier-list before 'spe_context_ptr_t' ./src/video/ps3/SDL_ps3video.c:78: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'fb_writer_spu' ./src/video/ps3/SDL_ps3video.c: In function 'PS3_VideoInit': ./src/video/ps3/SDL_ps3video.c:167: error: 'spu_data_t' has no member named 'program' ./src/video/ps3/SDL_ps3video.c:167: error: 'fb_writer_spu' undeclared (first use in this function) [...] The problem is that the ps3 video driver is being build regardless if libspe2 is installed or not. The attached patch fixes this problem. [ Note: The other headers that are being checked for are coming from the linux headers package on powerpc64. As a result these are also available if you're on a generic powerpc64 machine and not a PS3 only. ]
Fri, 11 Dec 2009 15:11:49 +0000 Fixed bug #899 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Fri, 11 Dec 2009 15:11:49 +0000] rev 4389
Fixed bug #899 Jeremiah Morris 2009-12-09 16:23:50 PST Re-enable mouseLocation workaround on 10.4, 10.5 OS X systems before 10.6 have a bug with [NSEvent mouseLocation] if the screen resolution changes. SDL_QuartzVideo.m contains a workaround for this bug, but it was placed inside an #ifdef in revision 4762. The comment reads, "I'm gambling they fixed this by 10.4." After seeing this bug on several Tiger and Leopard systems (both PPC and Intel), I can confirm that it's not fixed until 10.6. The workaround doesn't compile for x86_64/10.6, so I can understand why it was segregated, but it needs to remain in place for the i386 and ppc versions. The workaround causes no problems under 10.6, even though it's not necessary there. Patch is attached with one method of keeping the workaround active on the systems that need it.
Fri, 11 Dec 2009 08:00:57 +0000 Fixed bug #896 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Fri, 11 Dec 2009 08:00:57 +0000] rev 4388
Fixed bug #896 John Popplewell 2009-12-08 23:05:50 PST Originally reported by AKFoerster on the mailing list. Error decoding UTF8 Russian text to UTF-16LE on Windows, but specifically on platforms without iconv support (the default on Windows). Valid UTF8 characters are flagged as being overlong and then substituted by the UNKNOWN_UNICODE character. After studying the testiconv.c example program, reading the RFCs and putting some printf statements in SDL_iconv.c the problem is in a test for 'Maximum overlong sequences', specifically 4.2.1, which is carried out by the following code: } else if ( p[0] >= 0xC0 ) { if ( (p[0] & 0xE0) != 0xC0 ) { /* Skip illegal sequences return SDL_ICONV_EILSEQ; */ ch = UNKNOWN_UNICODE; } else { if ( (p[0] & 0xCE) == 0xC0 ) { <<<<<<<< here overlong = SDL_TRUE; } ch = (Uint32)(p[0] & 0x1F); left = 1; } } else { Here is the 2-byte encoding of a character in range 00000080 - 000007FF 110xxxxx 10xxxxxx The line in question is supposed to be checking for an overlong sequence which would be less than 11000001 10111111 which should be represented as a single byte. BUT, the mask value (0xCE) is wrong, it isn't checking the top-most bit: 11000001 value 11001110 mask (incorrect) ^ and should be (0xDE): 11000001 value 11011110 mask (correct) making the above code: } else if ( p[0] >= 0xC0 ) { if ( (p[0] & 0xE0) != 0xC0 ) { /* Skip illegal sequences return SDL_ICONV_EILSEQ; */ ch = UNKNOWN_UNICODE; } else { if ( (p[0] & 0xDE) == 0xC0 ) { <<<<<<<< here overlong = SDL_TRUE; } ch = (Uint32)(p[0] & 0x1F); left = 1; } } else { I can supply a test program and/or a patch if required, best regards, John Popplewell
Thu, 03 Dec 2009 04:20:46 +0000 Missing pop over a jump SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Thu, 03 Dec 2009 04:20:46 +0000] rev 4387
Missing pop over a jump
Wed, 02 Dec 2009 16:24:21 +0000 Fixed crash - need to save and restore rbx around cpuid, since the compiler may be assuming the stack pointer isn't being modified when filling in %0. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Wed, 02 Dec 2009 16:24:21 +0000] rev 4386
Fixed crash - need to save and restore rbx around cpuid, since the compiler may be assuming the stack pointer isn't being modified when filling in %0. I did it around each call to cpuid which isn't strictly necessary, but is definitely future proof. :)
Tue, 17 Nov 2009 05:14:23 +0000 Fixed bug #888 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 17 Nov 2009 05:14:23 +0000] rev 4385
Fixed bug #888 The OS/2 joystick code included an IBM header and was in violation of the license. Ryan may put this back someday with a legal header. :)
Tue, 17 Nov 2009 04:59:13 +0000 Fixed bugs #882 and 865, re-opening bug #634 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 17 Nov 2009 04:59:13 +0000] rev 4384
Fixed bugs #882 and 865, re-opening bug #634 Ronald Lamprecht to SDL Hi, Sam Lantinga wrote: The problem with that fix is that it breaks IME events again. Maybe we can handle keyboard events differently to prevent this issue? Spending an hour reading MSDN, analysing SDL and another hour testing the reality on XP I am really wondering how patch r4990 could have ever worked in any situation. It's main effect is to break the unicode translation and causing spurious activation events! Why does TranslateMessage(&msg) nothing useful? Simply because it does not affect "msg" at all! All keyboard events are dispatched without the slightest change (see MSDN). TranslateMessage() just appends additional WM_CHAR, WM_DEADCHAR, WM_SYSCHAR, WM_SYSDEADCHAR event messages to the queue. But I could not find any SDL event handling routine that catches these events and transforms them to proper SDL keyevents while eliminating the corresponding WM_KEYDOWN, etc. events. Thus any IME input like the '@' generated by "Alt + 6(Numpad) + 4(Numpad)" is simply lost. But the situation is even worse! Up to r4990 the TranslateKey()/ToUnicode() calls did evaluate dead keys and did deliver proper key events for subsequent key strokes like '´' + 'e' resulting in 'é'. ToUnicode() needs proper key state informations to be able to handle these substitutions. But unfortunatly TranslateMessage() needs the same state information and eats it up while generating the WM_CHAR messages :-( Thus the current 1.2.14 breakes the partial IME support of previous releases, too. The key state race condition between ToUnicode() and TranslateMessage() requires to avoid any ToUnicode() usage for receiving proper WM_CHAR, etc. messages generated by TranslateMessage(). (Yes - the '@' and 'é' appear as WM_CHAR messages when unicode is switched off). The spurious SDL activation events are *not* caused by additional WM_ACTIVATE Windows messages! Besides DIB_HandleMessage() SDL_PrivateAppActive() is called by another source which I am not yet aware of - any hints? Thus I do strongly recommend the deletion of the TranslateMessage(&msg) call as a quick fix. A proper support of unicode and IME requires a clean SDL keyboard input concept first. Which SDL keyboards events should be transmitted to the app when the user presses '´' + 'e' ? Within the current unicode handling the first key stroke is hidden. Even though ToUnicode() delivers the proper key SDL does ignore it in TranslateKey(). Just the composed key event is transmitted to the app. That is what you expect for text input, but the app can no longer use keys like '^' as a key button because it will never receive a key event for it! With a given concept it seems to be necessary to regenerate SDL key events out of the WM_CHAR, etc. events and to drop all related direct WM_KEYDOWN, etc. events while the remaining basic WM_KEYDOWN, etc. events would still have to result in SDL key events. Anyway the source of the spurious WM_ACTIVATE should be located to avoid future trouble. Greets, Ronald
Sun, 15 Nov 2009 17:21:24 +0000 Gregory Smith SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sun, 15 Nov 2009 17:21:24 +0000] rev 4383
Gregory Smith Another one for the "How did this ever work?" file: when DX5_HandleMessage is called with WM_ACTIVATEAPP, it goes past the end of the 2-element SDL_DIdev array and if there doesn't happen to be a 0 in the memory next to it, crashes. Patch against SVN attached.
Mon, 09 Nov 2009 18:02:32 +0000 Forgot a check for Coldfire CPU SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Mon, 09 Nov 2009 18:02:32 +0000] rev 4382
Forgot a check for Coldfire CPU
Sat, 07 Nov 2009 20:56:09 +0000 Adapt timer code for Coldfire SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Sat, 07 Nov 2009 20:56:09 +0000] rev 4381
Adapt timer code for Coldfire
Sat, 07 Nov 2009 20:45:45 +0000 Adapt audio interrupts for Coldfire SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Sat, 07 Nov 2009 20:45:45 +0000] rev 4380
Adapt audio interrupts for Coldfire
Sat, 07 Nov 2009 12:20:01 +0000 Adapt XBIOS asm routine for Coldfire SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Sat, 07 Nov 2009 12:20:01 +0000] rev 4379
Adapt XBIOS asm routine for Coldfire
Fri, 06 Nov 2009 22:43:51 +0000 Damn. Need to be more careful with stack stuff. SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Fri, 06 Nov 2009 22:43:51 +0000] rev 4378
Damn. Need to be more careful with stack stuff.
Fri, 06 Nov 2009 22:40:19 +0000 Oops. Forgot a change for Coldfire. SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Fri, 06 Nov 2009 22:40:19 +0000] rev 4377
Oops. Forgot a change for Coldfire.
Fri, 06 Nov 2009 22:32:16 +0000 Adapt IKBD asm routine for Coldfire SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Fri, 06 Nov 2009 22:32:16 +0000] rev 4376
Adapt IKBD asm routine for Coldfire
Fri, 06 Nov 2009 21:17:16 +0000 Disable C2P routines for Coldfire CPUs SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Fri, 06 Nov 2009 21:17:16 +0000] rev 4375
Disable C2P routines for Coldfire CPUs
Fri, 06 Nov 2009 18:06:01 +0000 Disable m68k assembly for Coldfire CPUs SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Fri, 06 Nov 2009 18:06:01 +0000] rev 4374
Disable m68k assembly for Coldfire CPUs
Fri, 06 Nov 2009 17:42:14 +0000 Update for include file locations SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Fri, 06 Nov 2009 17:42:14 +0000] rev 4373
Update for include file locations
Sun, 01 Nov 2009 17:51:39 +0000 1.2 branch: fixed assembly code register clobbering. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Sun, 01 Nov 2009 17:51:39 +0000] rev 4372
1.2 branch: fixed assembly code register clobbering.
Wed, 28 Oct 2009 19:42:16 +0000 fatbuild.sh: work around directory name change in Xcode 3.2. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Wed, 28 Oct 2009 19:42:16 +0000] rev 4371
fatbuild.sh: work around directory name change in Xcode 3.2.
Thu, 22 Oct 2009 04:53:44 +0000 C.W. Betts 2009-10-20 09:58:56 PDT SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Thu, 22 Oct 2009 04:53:44 +0000] rev 4370
C.W. Betts 2009-10-20 09:58:56 PDT The compiler complains that long is an incompatible pointer type for [gl_context setValues: forParameter:] and CGLSetParameter. This only shows up on x86_64, but it still might be an issue.
Tue, 20 Oct 2009 03:47:29 +0000 Better fix for bug #861 SDL-1.2 release-1.2.14
Sam Lantinga <slouken@libsdl.org> [Tue, 20 Oct 2009 03:47:29 +0000] rev 4369
Better fix for bug #861
Tue, 20 Oct 2009 03:45:06 +0000 Fixed bug #861 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 20 Oct 2009 03:45:06 +0000] rev 4368
Fixed bug #861 C.W. Betts 2009-10-19 19:16:41 PDT In 64-bit libraries, the fork reference is a different size than in 32-bit. Apple has tried to help this transition by making a typedef called FSIORefNum, but it is only available in Mac OS X 10.5 headers or later. I first noticed this bug in Mac OS X's CD player code, and the patch is set to fix it accordingly. This might also be an issue in SDL_QuartzVideo.m
Mon, 19 Oct 2009 10:09:58 +0000 Fixed compiler warnings SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 10:09:58 +0000] rev 4367
Fixed compiler warnings
Mon, 19 Oct 2009 10:03:16 +0000 Fixed bug #858 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 10:03:16 +0000] rev 4366
Fixed bug #858 Fixed compiler warning
Mon, 19 Oct 2009 10:02:00 +0000 Fixed bug #857 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 10:02:00 +0000] rev 4365
Fixed bug #857 Fixed compiler warnings
Mon, 19 Oct 2009 06:01:58 +0000 Whoops, missing newline! SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 06:01:58 +0000] rev 4364
Whoops, missing newline!
Mon, 19 Oct 2009 05:59:07 +0000 Added an untested code path for snd_pcm_wait() SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 05:59:07 +0000] rev 4363
Added an untested code path for snd_pcm_wait()
Mon, 19 Oct 2009 05:24:48 +0000 ALSA write failed (unrecoverable): Resource temporarily unavailable SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 05:24:48 +0000] rev 4362
ALSA write failed (unrecoverable): Resource temporarily unavailable
Mon, 19 Oct 2009 05:15:21 +0000 Added an error message for when ALSA audio fails SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 05:15:21 +0000] rev 4361
Added an error message for when ALSA audio fails
Mon, 19 Oct 2009 03:18:15 +0000 Getting as close as you can with periods is better than the default parameters. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 03:18:15 +0000] rev 4360
Getting as close as you can with periods is better than the default parameters.
Mon, 19 Oct 2009 02:36:02 +0000 Recoomendation from Lennart Poettering: SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 02:36:02 +0000] rev 4359
Recoomendation from Lennart Poettering: I guess I don't have to mention that, but ALSA_WaitAudio() is pure evil, and just broken. getpid() returns pids, not tids. You get those via gettid(). But I'd recommend dropping that entirely. It's just broken.
Mon, 19 Oct 2009 02:33:07 +0000 Recommendation from Lennart Poettering: SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 02:33:07 +0000] rev 4358
Recommendation from Lennart Poettering: In ALSA_PlayAudio() it is a good idea to use snd_pcm_recover() instead of checking for the error codes yourself.
Mon, 19 Oct 2009 02:23:21 +0000 Recommendation from Lennart Poettering: SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 02:23:21 +0000] rev 4357
Recommendation from Lennart Poettering: In ALSA_OpenAudio(): instead of setting period_size+n_periods OR buffer_size I'd recommend copying the hwparams stuff before you do this, then first try period_size+n_periods, and then apply it with snd_pcm_hw_params() and check if that works. If it didn't you should take the copy of hwparams and try setting buffer_size and apply that via snd_pcm_hw_params() and check if that worked. And if that failed too, then take the copy and don't apply neither period nor buffer settings and see if that works.
Sun, 18 Oct 2009 23:18:28 +0000 There's a bug with gcc 4.4.1 and -O2 where srcp doesn't get the correct value after the first scanline. Ugh. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sun, 18 Oct 2009 23:18:28 +0000] rev 4356
There's a bug with gcc 4.4.1 and -O2 where srcp doesn't get the correct value after the first scanline. Ugh.
Sun, 18 Oct 2009 17:31:37 +0000 Fixed bug #855 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sun, 18 Oct 2009 17:31:37 +0000] rev 4355
Fixed bug #855 Ludwig Nussel 2009-10-18 06:31:52 PDT an mprotect call was added to fix bug 528. However that results in a buffer that allows writing and code execution. Ie the no-execute security features of modern operating systems are defeated this way. Two mprotect calls are needed. One to make the buffer executable but not writeable when done and another one to make the buffer writeable again if the content needs to be changed.
Sun, 18 Oct 2009 16:23:12 +0000 Use MacOS line endings for Mac resource files SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sun, 18 Oct 2009 16:23:12 +0000] rev 4354
Use MacOS line endings for Mac resource files
Sun, 18 Oct 2009 16:17:13 +0000 Use MacOS line endings for SDL.x SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sun, 18 Oct 2009 16:17:13 +0000] rev 4353
Use MacOS line endings for SDL.x
Sun, 18 Oct 2009 16:14:57 +0000 Fixed bug #853 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sun, 18 Oct 2009 16:14:57 +0000] rev 4352
Fixed bug #853 Ludwig Nussel 2009-10-18 05:34:18 PDT src/joystick/linux/SDL_sysjoystick.c has some problems: - test_bit() might break with strict aliasing - test_bit() assumes array is Uint32 but its actually "unsigned long" on 64bit systems sizeof(long) != sizeof(Uint32). - the keybit array is too small - the arrays are unitialized so the number of detected buttons is quite random
Sat, 17 Oct 2009 17:35:48 +0000 We no longer have a DirectInput link requirement SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sat, 17 Oct 2009 17:35:48 +0000] rev 4351
We no longer have a DirectInput link requirement
Sat, 17 Oct 2009 16:49:23 +0000 Fixed bug #849 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sat, 17 Oct 2009 16:49:23 +0000] rev 4350
Fixed bug #849 This was a silly bug. :)
Sat, 17 Oct 2009 07:05:33 +0000 Don't need the define anymore... SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sat, 17 Oct 2009 07:05:33 +0000] rev 4349
Don't need the define anymore...
Sat, 17 Oct 2009 07:04:58 +0000 Enable the ALSA debug code via environment variable SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sat, 17 Oct 2009 07:04:58 +0000] rev 4348
Enable the ALSA debug code via environment variable
Sat, 17 Oct 2009 06:55:17 +0000 Option to fix bug #851 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sat, 17 Oct 2009 06:55:17 +0000] rev 4347
Option to fix bug #851 For some people setting the period size works better (and is what SDL 1.2.13 did), but for most people it's the same or worse. You can use an environment variable to pick which one you want.
Sat, 17 Oct 2009 05:05:29 +0000 matthew green SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sat, 17 Oct 2009 05:05:29 +0000] rev 4346
matthew green actually, please don't apply this upstream. i need to think about a better solution.. thanks. .mrg.
Fri, 16 Oct 2009 07:24:11 +0000 Allow the application to resize the window without destroying the OpenGL context SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Fri, 16 Oct 2009 07:24:11 +0000] rev 4345
Allow the application to resize the window without destroying the OpenGL context
Fri, 16 Oct 2009 05:12:20 +0000 patch-pulse (from ahoka@NetBSD.org): SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Fri, 16 Oct 2009 05:12:20 +0000] rev 4344
patch-pulse (from ahoka@NetBSD.org): Fix assertion triggered in pulsaudio by returning "unknown" instead of NULL pointer when guessing application name. - Use getprogname on NetBSD as it wont return NULL
Fri, 16 Oct 2009 05:06:17 +0000 patch-ac (from mrg@NetBSD.org): SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Fri, 16 Oct 2009 05:06:17 +0000] rev 4343
patch-ac (from mrg@NetBSD.org): Look for libGL.so, not any particular libGL.so.<X>, on NetBSD. (the comment inline explains why)
Fri, 16 Oct 2009 05:05:21 +0000 patch-ab (from reinoud@NetBSD.org): SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Fri, 16 Oct 2009 05:05:21 +0000] rev 4342
patch-ab (from reinoud@NetBSD.org): Apply patch to first unlock the CD before trying to eject it. Since SDL doesn't seem to have lock/unlock primitives, this looks like the right thing to do. Fixes audio/tcd's eject function too.
Fri, 16 Oct 2009 04:29:27 +0000 It helps to use the right constant. :) SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Fri, 16 Oct 2009 04:29:27 +0000] rev 4341
It helps to use the right constant. :)
Fri, 16 Oct 2009 04:24:03 +0000 Use SDL's byte order check, just to be sure SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Fri, 16 Oct 2009 04:24:03 +0000] rev 4340
Use SDL's byte order check, just to be sure
Thu, 15 Oct 2009 05:29:49 +0000 Don't call it "ALSA 0.9 PCM audio" anymore, since we moved to the stable API. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Thu, 15 Oct 2009 05:29:49 +0000] rev 4339
Don't call it "ALSA 0.9 PCM audio" anymore, since we moved to the stable API.
Thu, 15 Oct 2009 05:18:48 +0000 Fixed building on Mac OS X SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Thu, 15 Oct 2009 05:18:48 +0000] rev 4338
Fixed building on Mac OS X
Thu, 15 Oct 2009 02:52:11 +0000 Fixed bug #728 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Thu, 15 Oct 2009 02:52:11 +0000] rev 4337
Fixed bug #728 I am using a headset on my monitor as primary sound output device. From time to time it happens that I switch off my monitor when I leave my computer and switch it on when I come back. When doing so while wesnoth is running I get no sound back when I switch on my monitor. There is probably good reason for that. Therefore I wanted to exit and restart wesnoth. Unfortunately, wesnoth always hangs in this situation. It looks like wesnoth can not be exited when the primary sound device vanished. I created a backtrace of this situation (please see attachment).
Wed, 14 Oct 2009 07:34:35 +0000 Thilo helped me track down the audio issue with 22050 hz stereo sound. Yay! SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Wed, 14 Oct 2009 07:34:35 +0000] rev 4336
Thilo helped me track down the audio issue with 22050 hz stereo sound. Yay!
Tue, 13 Oct 2009 18:14:13 +0000 Add a note for experimental Milan support. SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Tue, 13 Oct 2009 18:14:13 +0000] rev 4335
Add a note for experimental Milan support.
Tue, 13 Oct 2009 09:59:20 +0000 Use the plug: ALSA devices for surround sound formats, which have automatic sample format/rate conversion. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Oct 2009 09:59:20 +0000] rev 4334
Use the plug: ALSA devices for surround sound formats, which have automatic sample format/rate conversion. Based on feedback from the ALSA development mailing list: http://mailman.alsa-project.org/pipermail/alsa-devel/2009-October/022267.html
Tue, 13 Oct 2009 09:56:15 +0000 Switched from setting the period size and count to setting the buffer size directly, based on feedback from the ALSA development list: SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Oct 2009 09:56:15 +0000] rev 4333
Switched from setting the period size and count to setting the buffer size directly, based on feedback from the ALSA development list: http://mailman.alsa-project.org/pipermail/alsa-devel/2009-October/022267.html This has the nice side effect of reducing latency on my SBLive! card.
Tue, 13 Oct 2009 09:35:37 +0000 ALSA's idea of a "frame" is the same as SDL's idea of a "sample". The frame is a single sample on a single channel, and we've defined the frames for each channel as being interleaved. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Oct 2009 09:35:37 +0000] rev 4332
ALSA's idea of a "frame" is the same as SDL's idea of a "sample". The frame is a single sample on a single channel, and we've defined the frames for each channel as being interleaved.
Tue, 13 Oct 2009 09:24:05 +0000 Fixed debug code to print correct values SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Oct 2009 09:24:05 +0000] rev 4331
Fixed debug code to print correct values Passed a meaningful value to snd_pcm_sw_params_set_start_threshold()
Tue, 13 Oct 2009 08:42:40 +0000 On recent distributions ALSA pipes streams through PulseAudio anyway, so using PulseAudio first when it's available will improve latency and reduce ALSA configuration quirks. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Oct 2009 08:42:40 +0000] rev 4330
On recent distributions ALSA pipes streams through PulseAudio anyway, so using PulseAudio first when it's available will improve latency and reduce ALSA configuration quirks.
Tue, 13 Oct 2009 08:27:28 +0000 Corrected my snd_pcm_writei fix. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Tue, 13 Oct 2009 08:27:28 +0000] rev 4329
Corrected my snd_pcm_writei fix. Apparently ALSA says "frames" but it means samples...you don't split this into groups by number of channels. The adventure continues.
Tue, 13 Oct 2009 06:45:02 +0000 Only show the dynamic audio libraries if we'll be dynamically loading them SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Oct 2009 06:45:02 +0000] rev 4328
Only show the dynamic audio libraries if we'll be dynamically loading them
Tue, 13 Oct 2009 05:20:09 +0000 Simplify and improve dynamic library detection, taken from SDL_image SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Oct 2009 05:20:09 +0000] rev 4327
Simplify and improve dynamic library detection, taken from SDL_image
Tue, 13 Oct 2009 04:23:34 +0000 We don't need dlvsym() for ALSA anymore, yay! SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Oct 2009 04:23:34 +0000] rev 4326
We don't need dlvsym() for ALSA anymore, yay!
Mon, 12 Oct 2009 23:21:19 +0000 Merged fix from SDL 1.3 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 12 Oct 2009 23:21:19 +0000] rev 4325
Merged fix from SDL 1.3
Mon, 12 Oct 2009 21:07:12 +0000 Steven Noonan to sdl SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 12 Oct 2009 21:07:12 +0000] rev 4324
Steven Noonan to sdl While trying to build the SDLMain.m included with SDL 1.2.14, with #define SDL_USE_NIB_FILE 1: /Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m: In function '-[SDLMain fixMenu:withAppName:]': /Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:122: warning: 'sizeToFit' is deprecated (declared at /Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSMenu.h:281) /Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m: In function 'main': /Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376: warning: 'poseAsClass:' is deprecated (declared at /Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127) /Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376: error: 'poseAsClass:' is unavailable (declared at /Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127) /Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:377: warning: passing argument 2 of 'NSApplicationMain' from incompatible pointer type Eric Wing to Sam I don't have time today to look at this in detail, but the problem is definitely the poseAsClass: method. This was deprecated in Obj-C 2.0 and not retained in 64-bit. I've never used this method and it has always been limited to esoteric uses. I think this is why Apple wanted to dump it (among complicating some other things they do). I have read about others getting bit by this when migrating. Long story short, there really isn't a migration path for this method. The question that then must be asked is why are we using it (what does it accomplish), and then figure out the 'proper' way of accomplishing that. Glancing at SDLMain.m, it's not obvious to me why it is there or what it is really accomplishing. My only speculation is that NSApplicationMain hardcodes something to look for NSApplication and a subclass (SDLApplication) fails for some reason (assuming that the original coder did this for good reason). Three thoughts come to mind. 1) The Info.plist has properties to control things related to the startup class and nib. NSPrincipalClass, NSMainNibFile Maybe principle class needs to be SDLApplication and we can delete the poseAs 2) I was told that 10.6 introduced new APIs to make programatic NIB wrangling and avoidance easier. Unfortunately, I don't know the specifics. 3) Instead of subclassing NSApplication in SDLMain.m, maybe we can just add a category. It looks like the following is the only thing that is done (quick glance): @interface SDLApplication : NSApplication @end @implementation SDLApplication /* Invoked from the Quit menu item */ - (void)terminate:(id)sender { /* Post a SDL_QUIT event */ SDL_Event event; event.type = SDL_QUIT; SDL_PushEvent(&event); } @end So instead, we change this to: (warning written in mail and untested) @interface NSApplication (SDLApplication) - (void) terminate:(id)sender; @end @implementation NSApplication (SDLApplication) /* Invoked from the Quit menu item */ - (void)terminate:(id)sender { /* Post a SDL_QUIT event */ SDL_Event event; event.type = SDL_QUIT; SDL_PushEvent(&event); } @end Then everywhere SDLApplication is used, we change it to NSApplication (and remove the poseAsClass line). Perhaps you could ask the bug reporter to try this solution (#3). And if that fails, maybe try #1. -Eric Steven Noonan to Sam The suggested change (diff below) seems to work fine. - Steven
Mon, 12 Oct 2009 09:32:55 +0000 Joystick patch from FreeBSD ports system SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 12 Oct 2009 09:32:55 +0000] rev 4323
Joystick patch from FreeBSD ports system
Mon, 12 Oct 2009 08:58:12 +0000 Forcibly disabled MMX mixers. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Mon, 12 Oct 2009 08:58:12 +0000] rev 4322
Forcibly disabled MMX mixers. Hopefully fixes Bugzilla #649.
Mon, 12 Oct 2009 08:18:36 +0000 Whoops, need to convert from bits to bytes for frame size. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Mon, 12 Oct 2009 08:18:36 +0000] rev 4321
Whoops, need to convert from bits to bytes for frame size.
Mon, 12 Oct 2009 08:06:40 +0000 Corrected misuse of snd_pcm_writei() in ALSA driver. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Mon, 12 Oct 2009 08:06:40 +0000] rev 4320
Corrected misuse of snd_pcm_writei() in ALSA driver. Hopefully fixes Bugzilla #650.
Sat, 10 Oct 2009 15:10:06 +0000 Added support for SDL_VIDEO_FULLSCREEN_DISPLAY, but mouse events need to be fixed up. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sat, 10 Oct 2009 15:10:06 +0000] rev 4319
Added support for SDL_VIDEO_FULLSCREEN_DISPLAY, but mouse events need to be fixed up.
Sat, 10 Oct 2009 15:06:04 +0000 Added SDL_VIDEO_FULLSCREEN_DISPLAY as a preferred synonym for SDL_VIDEO_FULLSCREEN_HEAD on X11. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sat, 10 Oct 2009 15:06:04 +0000] rev 4318
Added SDL_VIDEO_FULLSCREEN_DISPLAY as a preferred synonym for SDL_VIDEO_FULLSCREEN_HEAD on X11.
Sat, 10 Oct 2009 14:59:32 +0000 Put the braces on the next line so vi can find the beginning of the function. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sat, 10 Oct 2009 14:59:32 +0000] rev 4317
Put the braces on the next line so vi can find the beginning of the function.
Sat, 10 Oct 2009 10:28:05 +0000 Disable double buffer for Milan. Also set current width,height after we read it. SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Sat, 10 Oct 2009 10:28:05 +0000] rev 4316
Disable double buffer for Milan. Also set current width,height after we read it.
Sat, 10 Oct 2009 10:17:51 +0000 Added missing caca files SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sat, 10 Oct 2009 10:17:51 +0000] rev 4315
Added missing caca files
Sat, 10 Oct 2009 10:15:35 +0000 Fixed bug #838 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sat, 10 Oct 2009 10:15:35 +0000] rev 4314
Fixed bug #838 Ozkan Sezer 2009-10-10 01:45:27 PDT sdlenvvars.html doesn't list pulse among the supported values for SDL_AUDIODRIVER var. Attached a quick patch to remedy that, hopefully placing the entry in the right order. Regards.
(0) -3000 -1000 -120 +120 +1000 +3000 tip