Sun, 31 May 2015 00:58:43 -0400 X11: Fixed high mouse buttons mappings and horizontal wheels (thanks, Daniel!).
Ryan C. Gordon <icculus@icculus.org> [Sun, 31 May 2015 00:58:43 -0400] rev 9686
X11: Fixed high mouse buttons mappings and horizontal wheels (thanks, Daniel!). Fixes Bugzilla #2472.
Sun, 31 May 2015 00:50:30 -0400 Cocoa: ignore mouseDown events in a window's titlebar.
Ryan C. Gordon <icculus@icculus.org> [Sun, 31 May 2015 00:50:30 -0400] rev 9685
Cocoa: ignore mouseDown events in a window's titlebar. These events accidentally slipping in sometimes appears to be a bug (or maybe new behavior) in 10.10, as previous versions of Mac OS X don't appear to ever trigger this. Thanks to Paulo Marques for pointing out the fix on the SDL mailing list! Fixes Bugzilla #2842 (again).
Fri, 29 May 2015 22:24:38 +0200 Fixed typo in header file documentation comment.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Fri, 29 May 2015 22:24:38 +0200] rev 9684
Fixed typo in header file documentation comment.
Fri, 29 May 2015 15:21:47 -0400 X11: Force the window focus during ShowWindow if there's no window manager.
Ryan C. Gordon <icculus@icculus.org> [Fri, 29 May 2015 15:21:47 -0400] rev 9683
X11: Force the window focus during ShowWindow if there's no window manager. Fixes Bugzilla #2997.
Thu, 28 May 2015 19:06:07 -0700 Improved fix for bug 2096 - Mapping from scancode to keycode doesn't work for remapped modifier keys
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 19:06:07 -0700] rev 9682
Improved fix for bug 2096 - Mapping from scancode to keycode doesn't work for remapped modifier keys Zack Middleton The change to the keymap to use SDL_SCANCODE_TO_KEYCODE in SDL_x11keyboard.c causes all SDL scancodes without a Usc4 character to be XOR'd with SDLK_SCANCODE_MASK, but not all key code are suppose to be (as seen in include/SDL_keycodes.h). SDLK_BACKSPACE is not 0x4000002A. I think the full list of keys affected are return, escape, backspace, tab, and delete.
Thu, 28 May 2015 18:57:57 -0700 Fixed building test programs on the iOS simulator
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 18:57:57 -0700] rev 9681
Fixed building test programs on the iOS simulator
Thu, 28 May 2015 18:57:10 -0700 Fixed clip rectangle calculation when there is a viewport offset
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 18:57:10 -0700] rev 9680
Fixed clip rectangle calculation when there is a viewport offset
Thu, 28 May 2015 12:55:01 -0700 Fixed bug 2054 - SDL_GetError: "Unknown touch device"
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 12:55:01 -0700] rev 9679
Fixed bug 2054 - SDL_GetError: "Unknown touch device" Volumetric The "Unknown touch device" message appears because the initial touch device setup loop uses SDL_GetTouch() as a guard for calling SDL_AddTouch(). SDL_GetTouch() will always report "Unknown touch device" since the device hasn't been added yet. The SDL_GetTouch() call is unnecessary since SDL_AddTouch() calls SDL_GetTouchIndex() to verify that the device hasn't been added yet, and SDL_GetTouchIndex() has the benefit of not reporting an error for a device it can't find.
Thu, 28 May 2015 12:48:20 -0700 Fixed bug 2096 - Mapping from scancode to keycode doesn't work for remapped modifier keys
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 12:48:20 -0700] rev 9678
Fixed bug 2096 - Mapping from scancode to keycode doesn't work for remapped modifier keys Jacob Lee If a user has a non-standard keyboard mapping -- say, their caps lock key has been mapped to Ctrl -- then SDL_GetModState() is no longer accurate: it only considers the unmapped keys. This is a regression from SDL 1.2. I think there are two parts to this bug: first, GetModState should use keycodes, rather than scancodes, which is easy enough. Unfortunately, on my system, SDL considers Caps Lock, even when mapped as Control, to be both SDL_SCANCODE_CAPSLOCK and SDLK_CAPSLOCK. The output from checkkeys for it is: INFO: Key pressed : scancode 57 = CapsLock, keycode 0x40000039 = CapsLock modifiers: CAPS Whereas the output for xev is: KeyPress event, serial 41, synthetic NO, window 0x4a00001, root 0x9a, subw 0x0, time 40218333, (144,177), root:(1458,222), state 0x10, keycode 66 (keysym 0xffe3, Control_L), same_screen YES, XKeysymToKeycode returns keycode: 37 XLookupString gives 0 bytes: XmbLookupString gives 0 bytes: XFilterEvent returns: False I think the problem is that X11_UpdateKeymap in SDL_x11keyboard.c only builds a mapping for keycodes associated with a Unicode character (anything where X11_KeyCodeToUcs returns a value). In the case of caps lock, SDL scancode 57 becomes x11 keycode 66, which becomes x11 keysym 65507(Control_L), which does not have a unicode value. To fix this, I suspect that SDL needs a mapping of the rest of the x11 keysyms to their corresponding SDL key codes.
Thu, 28 May 2015 15:36:27 -0400 Windows SDL_GetBasePath: free string on failure.
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 15:36:27 -0400] rev 9677
Windows SDL_GetBasePath: free string on failure.
Thu, 28 May 2015 15:32:45 -0400 Windows GetBasePath: fixed reallocation code.
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 15:32:45 -0400] rev 9676
Windows GetBasePath: fixed reallocation code.
Thu, 28 May 2015 15:29:43 -0400 Windows SDL_GetBasePath: Fixed wrong variable when growing the buffer size.
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 15:29:43 -0400] rev 9675
Windows SDL_GetBasePath: Fixed wrong variable when growing the buffer size.
Thu, 28 May 2015 12:31:25 -0700 Fixed bug 2210 - Initializing Video produces unnecessary errors
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 12:31:25 -0700] rev 9674
Fixed bug 2210 - Initializing Video produces unnecessary errors hiduei Overview: Initializing the Video Subsystem causes many errors though everything works as it should. Steps to Reproduce: 1) Set Loglevel to SDL_LOG_PRIORITY_ERROR 2) Initialize the Video Subsystem (SDL_Init(SDL_INIT_VIDEO)) Actual Results: Many errors (see attachment) are printed on stderr, then the application continues as expected. Expected Results: The errors should have been warnings at most.
Thu, 28 May 2015 12:18:05 -0700 Fixed bug 2367 - Bad mouse motion coordinates with two windows where one has changed logical size
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 12:18:05 -0700] rev 9673
Fixed bug 2367 - Bad mouse motion coordinates with two windows where one has changed logical size Andreas Ragnerstam I have two windows where one has a renderer where the logical size has been changed with SDL_RenderSetLogicalSize. When I get SDL_MOUSEMOTION events belonging to the non-scaled window these will have been scaled with the factor of the scaled window, which is not expected. Adding some printf debugging to SDL_RendererEventWatch of SDL_render.c, where (event->type == SDL_MOUSEMOTION), I found that for every mouse motion SDL_RendererEventWatch is called twice and the event->motion.x and event.motion.y are set twice for the event, once for each renderer where only the last one set will be saved to the event struct. This will work fine if both renderers have the same scale, but otherwise the motion coordinates will be scaled for the renderer belonging to another window than the mouse was moved in. I guess one solution would be to check that window == renderer->window for SDL_MOUSEMOTION events, similar to what is done for when SDL_WINDOWEVENT events. I get the same error on both X11 and Windows. The same problem also exists for SDL_MOUSEBUTTONDOWN and SDL_MOUSEBUTTONUP events.
Thu, 28 May 2015 12:06:48 -0700 Fixed compiling and tested on Windows
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 12:06:48 -0700] rev 9672
Fixed compiling and tested on Windows
Thu, 28 May 2015 01:54:52 -0400 Windows GetBasePath should use GetModuleFileNameExW() and check for overflows.
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 01:54:52 -0400] rev 9671
Windows GetBasePath should use GetModuleFileNameExW() and check for overflows. Apparently you might get strange paths from GetModuleFileName(), such as short path names or UNC filenames, so this avoids that problem. Since you have to tapdance with linking different libraries and defining macros depending on what Windows you plan to target, we dynamically load the API we need, which works on all versions of Windows (on Win7, it'll load a compatibility wrapper for the newer API location). What a mess. This also now does the right thing if there isn't enough space to store the path, looping with a larger allocated buffer each try. Fixes Bugzilla #2435.
Thu, 28 May 2015 14:34:38 -0400 Make sure we have the vsscanf() prototype (thanks, Ozkan!).
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 14:34:38 -0400] rev 9670
Make sure we have the vsscanf() prototype (thanks, Ozkan!). issue seen with glibc-2.8. Fixes Bugzilla #2721.
Thu, 28 May 2015 10:44:46 -0700 Fixed bug 2772 - SDL2 doesn't handle X KeymapNotify events
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 10:44:46 -0700] rev 9669
Fixed bug 2772 - SDL2 doesn't handle X KeymapNotify events Jason Wyatt Currently the keymapnotify event handling is commented out as FIXME in SDL_x11events.c (It looks like this may have functioned SDL1.2). Not handling this event means that if a window manager shortcut such as ALT+SPACE is used, SDL will send an ALT key down signal, but not an up signal. Also querying SDL about the key state, it believes the ALT key remains pressed. X passes the events keypress (alt), ?focusout?, ?focusin?, keymapnotify.
Sat, 20 Dec 2014 11:45:39 -0500 Partial fix for bug 2726 - Win32 'mouse' events not applying 'SDL_TOUCH_MOUSEID'
David Ludwig <dludwig@pobox.com> [Sat, 20 Dec 2014 11:45:39 -0500] rev 9668
Partial fix for bug 2726 - Win32 'mouse' events not applying 'SDL_TOUCH_MOUSEID' This is a Win32-specific fix for bug 2726. A WinRT fix for this bug was applied separately, via https://hg.libsdl.org/SDL/rev/bea2e725e29a This fix applies SDL_TOUCH_MOUSEID to 'mouse' events coming from touch devices, but only when relative-mouse-mode is turned OFF. This bug is still present when relative-mouse-mode is ON, however Microsoft does not provide documentation on whether or not those input events (which come from WM_INPUT) can be identified as touch-specific or not. Unofficially, that data might be available (via GetMessageExtraInfo()), however this patch only uses MS-documented APIs.
Thu, 28 May 2015 09:52:48 -0700 Fixed X11 build, added code to print initial modifiers to checkkeys
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 09:52:48 -0700] rev 9667
Fixed X11 build, added code to print initial modifiers to checkkeys
Thu, 28 May 2015 09:33:47 -0700 Fixed bug 2736 - X11 doesn't set KMOD_NUM and KMOD_CAPS to system state
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 09:33:47 -0700] rev 9666
Fixed bug 2736 - X11 doesn't set KMOD_NUM and KMOD_CAPS to system state Zack Middleton Using X11 (on Debian Wheezy), SDL_GetModState() & KMOD_NUM and KMOD_CAPS are not set to system state (numlock/capslock LEDs). Pressing numlock or capslock toggles the mod state, though if num/caps lock is enabled before starting the program it's still reversed from system state. This makes getting KMOD_NUM and KMOD_CAPS in programs unreliable. This can be seen using the checkkeys test program. The function that appears to have handle this in SDL 1.2 is X11_SetKeyboardState. The function call is commented out with "FIXME:" in SDL 2. Using Windows backend through WINE; on first key press if numlock and/or capslock is enabled on system, numlock/capslock SDL_SendKeyboardKey is run and toggles KMOD_NUM/KMOD_CAPS to the correct state. On X11 this does not happen. The attached patch makes X11 backend set keyboard state on window focus if no window was previously focused. It sets all keys to system up/down state and toggles KMOD_NUM/KMOD_CAPS via SDL_SendKeyboardKey to match system if needed. The patch is based on SDL 1.2's X11_SetKeyboardState.
Thu, 28 May 2015 08:51:59 -0700 Fixed Windows build
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 08:51:59 -0700] rev 9665
Fixed Windows build
Thu, 28 May 2015 08:41:07 -0700 Fixed bug 2860 - SetProp must be paired with RemoveProp especially for properties added to external windows
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 08:41:07 -0700] rev 9664
Fixed bug 2860 - SetProp must be paired with RemoveProp especially for properties added to external windows Coriiander Upon creating a window, a window property is added to it through the Win32-function "SetProp". This is done in the SDL-function "SetupWindowData" in file "src\video\windows\SDL_windowswindow.c". Whenever you call "SetProp" to add a property to a Win32-window, you should also call the Win32-function "RemoveProp" to remove it before destroying that Win32-window. While you might think that it's ok and that Windows will clean up nicely itself, it is not ok. It is against all Win32-API guidelines and is mostlikely a leak. Especially on external windows (CreateWindowFrom) you want to have things done right, not messy and leaky, affecting some other module. Even if SDL gets shutdown entirely that external window will now forever still have the "SDL_WindowData" prop attached to it.
Thu, 28 May 2015 01:27:24 -0400 I think this will be the time...
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 01:27:24 -0400] rev 9663
I think this will be the time...
Thu, 28 May 2015 01:22:14 -0400 Still trying to get this to compile...
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 01:22:14 -0400] rev 9662
Still trying to get this to compile...
Thu, 28 May 2015 01:16:55 -0400 More patching to compile...
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 01:16:55 -0400] rev 9661
More patching to compile...
Thu, 28 May 2015 01:08:33 -0400 Another attempt to get this to compile.
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 01:08:33 -0400] rev 9660
Another attempt to get this to compile.
Thu, 28 May 2015 01:02:03 -0400 Patched to compile on MingW.
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 01:02:03 -0400] rev 9659
Patched to compile on MingW. (I think!)
Thu, 28 May 2015 00:54:52 -0400 Move tests from SDL_config higher up in Windows joystick/haptic code.
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 00:54:52 -0400] rev 9658
Move tests from SDL_config higher up in Windows joystick/haptic code. Fixes Bugzilla #2932.
Thu, 28 May 2015 00:30:21 -0400 X11: Add Xdbe support to message boxes (thanks, Melker!).
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 00:30:21 -0400] rev 9657
X11: Add Xdbe support to message boxes (thanks, Melker!). Without this, message boxes with a lot of text will noticibly flicker as you mouse over buttons. Fixes Bugzilla #2343.
(0) -3000 -1000 -300 -100 -50 -30 +30 +50 +100 +300 tip