# HG changeset patch
# User Sam Lantinga <slouken@libsdl.org>
# Date 1326253937 18000
# Node ID beb988469d26732c50398c226676d14115e89d80
# Parent  ceb6db0058f1e0c79e0c258fb5538e6024942b14
Fixed typo in mask comparison


Bl0ckeduser

I downloaded the SDL 1.2.15 prerelease and compiled it (under Mac OS
Classic). All the tests worked without issues, but the compiler gave
this warning [formatting edited for email format]:

    } else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) {

":src:video:SDL_video.c"; line 990 #Warning 2: possible unintended assignment

I discussed this with another programmer and we came to the conclusion
that this is probably a typo.

I have checked the latest mercurial sources, and the possible typo is
still there.

Bl0ckeduser

diff -r ceb6db0058f1 -r beb988469d26 src/video/SDL_video.c
--- a/src/video/SDL_video.c	Tue Jan 10 21:12:45 2012 +0100
+++ b/src/video/SDL_video.c	Tue Jan 10 22:52:17 2012 -0500
@@ -987,7 +987,7 @@
 		if ( (vf->Rmask == 0xff) && (vf->Bmask == 0xff0000) ) {
 			rmask = 0xff;
 			bmask = 0xff0000;
-		} else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) {
+		} else if ( vf->Rmask == 0xFF00 && (vf->Bmask == 0xFF000000) ) {
 			amask = 0x000000FF;
 			rmask = 0x0000FF00;
 			gmask = 0x00FF0000;