Date: Sun, 29 Feb 2004 20:28:27 +0200
From: Martin_Storsj
Subject: Slight bug in ESD and aRts
When I experimented with the ALSA-patch, I found a slight bug in the
Load{ESD,ARTS}Library-functions. The check of whether a function pointer
was correctly loaded looks like this right now:
*esd_functions[i].func = SDL_LoadFunction(esd_handle,
esd_functions[i].name);
if ( ! esd_functions[i].func )
Isn't that supposed to be ( ! *esd_functions[i].func )?
--- a/src/audio/arts/SDL_artsaudio.c Tue Mar 02 12:38:27 2004 +0000
+++ b/src/audio/arts/SDL_artsaudio.c Tue Mar 02 12:45:22 2004 +0000
@@ -106,7 +106,7 @@
retval = 0;
for ( i=0; i<SDL_TABLESIZE(arts_functions); ++i ) {
*arts_functions[i].func = SDL_LoadFunction(arts_handle, arts_functions[i].name);
- if ( ! arts_functions[i].func ) {
+ if ( !*arts_functions[i].func ) {
retval = -1;
UnloadARTSLibrary();
break;
--- a/src/audio/esd/SDL_esdaudio.c Tue Mar 02 12:38:27 2004 +0000
+++ b/src/audio/esd/SDL_esdaudio.c Tue Mar 02 12:45:22 2004 +0000
@@ -101,7 +101,7 @@
retval = 0;
for ( i=0; i<SDL_TABLESIZE(esd_functions); ++i ) {
*esd_functions[i].func = SDL_LoadFunction(esd_handle, esd_functions[i].name);
- if ( ! esd_functions[i].func ) {
+ if ( !*esd_functions[i].func ) {
retval = -1;
UnloadESDLibrary();
break;