Static analysis fix: uninitialized variables.
authorRyan C. Gordon <icculus@icculus.org>
Thu, 20 Mar 2014 10:41:47 -0400
changeset 8649 4ee50f124da2
parent 8648 2b3eec53c66b
child 8650 058c88ce501c
Static analysis fix: uninitialized variables. This is actually a false-positive, in this case, since Clang doesn't know that SDL_SetError() only ever returns -1. Feature request to improve that, with explanation about these specific SDL patches, is here: http://llvm.org/bugs/show_bug.cgi?id=19208
src/render/SDL_render.c
--- a/src/render/SDL_render.c	Thu Mar 20 10:04:23 2014 -0400
+++ b/src/render/SDL_render.c	Thu Mar 20 10:41:47 2014 -0400
@@ -970,8 +970,8 @@
 SDL_UnlockTextureYUV(SDL_Texture * texture)
 {
     SDL_Texture *native = texture->native;
-    void *native_pixels;
-    int native_pitch;
+    void *native_pixels = NULL;
+    int native_pitch = 0;
     SDL_Rect rect;
 
     rect.x = 0;
@@ -991,8 +991,8 @@
 SDL_UnlockTextureNative(SDL_Texture * texture)
 {
     SDL_Texture *native = texture->native;
-    void *native_pixels;
-    int native_pitch;
+    void *native_pixels = NULL;
+    int native_pitch = 0;
     const SDL_Rect *rect = &texture->locked_rect;
     const void* pixels = (void *) ((Uint8 *) texture->pixels +
                         rect->y * texture->pitch +