Removed an ugly hack to make windows rotate properly on iOS 8+. iOS-improvements
authorAlex Szpakowski <slime73@gmail.com>
Sun, 23 Nov 2014 23:29:24 -0400
branchiOS-improvements
changeset 9528 6915f7db6791
parent 9527 bbd9326ecacf
child 9529 4bf9830d8153
Removed an ugly hack to make windows rotate properly on iOS 8+. Recent commits apparently resolved the issue that made the hack necessary.
src/video/uikit/SDL_uikitwindow.h
src/video/uikit/SDL_uikitwindow.m
--- a/src/video/uikit/SDL_uikitwindow.h	Sun Nov 23 23:23:47 2014 -0400
+++ b/src/video/uikit/SDL_uikitwindow.h	Sun Nov 23 23:29:24 2014 -0400
@@ -40,13 +40,9 @@
 
 @class UIWindow;
 
-@interface SDL_uikitwindow : UIWindow
-
-@end
-
 @interface SDL_WindowData : NSObject
 
-@property (nonatomic, strong) SDL_uikitwindow *uiwindow;
+@property (nonatomic, strong) UIWindow *uiwindow;
 @property (nonatomic, strong) SDL_uikitopenglview *view;
 @property (nonatomic, strong) SDL_uikitviewcontroller *viewcontroller;
 
--- a/src/video/uikit/SDL_uikitwindow.m	Sun Nov 23 23:23:47 2014 -0400
+++ b/src/video/uikit/SDL_uikitwindow.m	Sun Nov 23 23:29:24 2014 -0400
@@ -41,21 +41,6 @@
 
 #include <Foundation/Foundation.h>
 
-@implementation SDL_uikitwindow
-
-- (void)layoutSubviews
-{
-    [super layoutSubviews];
-
-    /* This seems to be needed on iOS 8, otherwise the window's frame is put in
-     * an unexpected position when the screen or device is rotated.
-     * FIXME: is there a better solution to that problem than this ugly hack?
-     */
-    self.frame = self.screen.bounds;
-}
-
-@end
-
 @implementation SDL_WindowData
 
 @synthesize uiwindow;
@@ -65,7 +50,7 @@
 @end
 
 
-static int SetupWindowData(_THIS, SDL_Window *window, SDL_uikitwindow *uiwindow, SDL_bool created)
+static int SetupWindowData(_THIS, SDL_Window *window, UIWindow *uiwindow, SDL_bool created)
 {
     SDL_VideoDisplay *display = SDL_GetDisplayForWindow(window);
     SDL_DisplayData *displaydata = (__bridge SDL_DisplayData *) display->driverdata;
@@ -213,7 +198,7 @@
 
         /* ignore the size user requested, and make a fullscreen window */
         /* !!! FIXME: can we have a smaller view? */
-        SDL_uikitwindow *uiwindow = [[SDL_uikitwindow alloc] initWithFrame:data.uiscreen.bounds];
+        UIWindow *uiwindow = [[UIWindow alloc] initWithFrame:data.uiscreen.bounds];
 
         /* put the window on an external display if appropriate. This implicitly
          * does [uiwindow setframe:[uiscreen bounds]], so don't do it on the