WinRT: allowed 'roaming' and 'temp' folder paths to be retrieved on WinPhone 8.1
authorDavid Ludwig <dludwig@pobox.com>
Sun, 23 Nov 2014 08:52:10 -0500
changeset 9228 9ecf7c9f49e5
parent 9227 4d9126f64347
child 9229 c4ff10b9a23c
WinRT: allowed 'roaming' and 'temp' folder paths to be retrieved on WinPhone 8.1 Windows Phone 8.0 either did not define, or provide access to, a 'RoamingFolder' or 'TemporaryFolder' for apps to use. Windows 8.0 and 8.1 do, as does Windows Phone 8.1. This change allows SDL-based Windows Phone 8.1 apps to access these folders, via either the SDL_WinRTGetFSPathUNICODE() or SDL_WinRTGetFSPathUTF8() functions. SDL_GetPrefPath(), which on WinRT, is based on SDL_WinRTGetFSPathUTF8(), will continue to return the app's 'local' folder, despite Windows 8.x counterpart apps using the 'roaming' folder, in order to preserve compatibility when 8.0-based Phone apps upgrade to 8.1-based Phone apps.
src/filesystem/winrt/SDL_sysfilesystem.cpp
--- a/src/filesystem/winrt/SDL_sysfilesystem.cpp	Sun Nov 23 11:26:46 2014 +0100
+++ b/src/filesystem/winrt/SDL_sysfilesystem.cpp	Sun Nov 23 08:52:10 2014 -0500
@@ -62,7 +62,7 @@
             return path.c_str();
         }
 
-#if WINAPI_FAMILY != WINAPI_FAMILY_PHONE_APP
+#if (WINAPI_FAMILY != WINAPI_FAMILY_PHONE_APP) || (NTDDI_VERSION > NTDDI_WIN8)
         case SDL_WINRT_PATH_ROAMING_FOLDER:
         {
             static wstring path;
@@ -145,10 +145,16 @@
      */
 
 #if WINAPI_FAMILY == WINAPI_FAMILY_PHONE_APP
-    /* A 'Roaming' folder is not available in Windows Phone 8, however a 'Local' folder is. */
+    /* A 'Roaming' folder is not available in Windows Phone 8.0, however a
+     * 'Local' folder is.  Use the 'Local' folder in order to preserve
+     * compatibility with Windows Phone 8.0, and with app-installs that have
+     * been updated from 8.0-based, to 8.1-based apps.
+     */
     const char * srcPath = SDL_WinRTGetFSPathUTF8(SDL_WINRT_PATH_LOCAL_FOLDER);
 #else
-    /* A 'Roaming' folder is available on Windows 8 and 8.1.  Use that. */
+    /* A 'Roaming' folder is available on Windows 8 and 8.1.  Use that.
+     * (SDL for Win32/Windows-Desktop uses the 'roaming' path as well).
+     */
     const char * srcPath = SDL_WinRTGetFSPathUTF8(SDL_WINRT_PATH_ROAMING_FOLDER);
 #endif