Hi Sam SDL-1.2
authorSam Lantinga <slouken@libsdl.org>
Fri, 02 Dec 2011 18:35:04 -0500
branchSDL-1.2
changeset 6099 c5d651a8b679
parent 6087 185f8588deaa
child 6109 469e95e71627
Hi Sam In X11_CreateYUVOverlay hwdata->image will be accessed after it has been freed, causing undefined behavior. Exchanging two lines as shown in this patch will fix that problem: Regards, Bodo
src/video/x11/SDL_x11yuv.c
--- a/src/video/x11/SDL_x11yuv.c	Thu Nov 17 03:12:34 2011 -0500
+++ b/src/video/x11/SDL_x11yuv.c	Fri Dec 02 18:35:04 2011 -0500
@@ -330,8 +330,8 @@
 #ifdef PITCH_WORKAROUND
 	if ( hwdata->image != NULL && hwdata->image->pitches[0] != (width*bpp) ) {
 		/* Ajust overlay width according to pitch */ 
+		width = hwdata->image->pitches[0] / bpp;
 		XFree(hwdata->image);
-		width = hwdata->image->pitches[0] / bpp;
 		hwdata->image = SDL_NAME(XvShmCreateImage)(GFX_Display, xv_port, format,
 							   0, width, height, yuvshm);
 	}