7z: copy/paste error in error checking, found by static analysis. stable-3.0
authorRyan C. Gordon <icculus@icculus.org>
Sun, 17 May 2020 01:26:31 -0400
branchstable-3.0
changeset 1690 165d972bc790
parent 1688 62804a972e79
7z: copy/paste error in error checking, found by static analysis. This was clearly copied from a previous line but wasn't updated with the correct condition to check, so if malloc() failed, it would dereference NULL instead of reporting an error. (transplanted from 1dc6e265fefcc1fec8d68f096a73e1dca4bf0691)
src/physfs_archiver_7z.c
--- a/src/physfs_archiver_7z.c	Sun May 17 00:58:55 2020 -0400
+++ b/src/physfs_archiver_7z.c	Sun May 17 01:26:31 2020 -0400
@@ -290,7 +290,7 @@
     io = NULL;
 
     buf = allocator.Malloc(outSizeProcessed);
-    GOTO_IF(rc != SZ_OK, PHYSFS_ERR_OUT_OF_MEMORY, SZIP_openRead_failed);
+    GOTO_IF(buf == NULL, PHYSFS_ERR_OUT_OF_MEMORY, SZIP_openRead_failed);
     memcpy(buf, outBuffer + offset, outSizeProcessed);
 
     alloc->Free(alloc, outBuffer);