From 44fb6d5e2daa73d3b8e67ec8c3d63a3f3e6c7da6 Mon Sep 17 00:00:00 2001 From: "Ryan C. Gordon" Date: Fri, 7 Feb 2014 16:17:48 -0500 Subject: [PATCH] Renamed a function to make Clang static analysis happy. "Object leaked: allocated object is returned from a function whose name ('cfallocDesc') does not contain 'Copy' or 'Create'. This violates the naming convention rules given in the Memory Management Guide for Core Foundation" (it doesn't actually leak, but okay, it's a reasonable naming convention.) --- src/platform_macosx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/platform_macosx.c b/src/platform_macosx.c index 802826ae..c10a399f 100644 --- a/src/platform_macosx.c +++ b/src/platform_macosx.c @@ -32,11 +32,11 @@ /* Wrap PHYSFS_Allocator in a CFAllocator... */ static CFAllocatorRef cfallocator = NULL; -static CFStringRef cfallocDesc(const void *info) +static CFStringRef cfallocCopyDesc(const void *info) { return CFStringCreateWithCString(cfallocator, "PhysicsFS", kCFStringEncodingASCII); -} /* cfallocDesc */ +} /* cfallocCopyDesc */ static void *cfallocMalloc(CFIndex allocSize, CFOptionFlags hint, void *info) @@ -65,7 +65,7 @@ int __PHYSFS_platformInit(void) /* set up a CFAllocator, so Carbon can use the physfs allocator, too. */ CFAllocatorContext ctx; memset(&ctx, '\0', sizeof (ctx)); - ctx.copyDescription = cfallocDesc; + ctx.copyDescription = cfallocCopyDesc; ctx.allocate = cfallocMalloc; ctx.reallocate = cfallocRealloc; ctx.deallocate = cfallocFree;