Renamed a function to make Clang static analysis happy.
authorRyan C. Gordon <icculus@icculus.org>
Fri, 07 Feb 2014 16:17:48 -0500
changeset 1342 3ff2a5a43b84
parent 1341 a16e890cd34b
child 1343 26cfac1a1f6f
Renamed a function to make Clang static analysis happy. "Object leaked: allocated object is returned from a function whose name ('cfallocDesc') does not contain 'Copy' or 'Create'. This violates the naming convention rules given in the Memory Management Guide for Core Foundation" (it doesn't actually leak, but okay, it's a reasonable naming convention.)
src/platform_macosx.c
--- a/src/platform_macosx.c	Thu Jan 16 07:03:42 2014 -0800
+++ b/src/platform_macosx.c	Fri Feb 07 16:17:48 2014 -0500
@@ -32,11 +32,11 @@
 /* Wrap PHYSFS_Allocator in a CFAllocator... */
 static CFAllocatorRef cfallocator = NULL;
 
-static CFStringRef cfallocDesc(const void *info)
+static CFStringRef cfallocCopyDesc(const void *info)
 {
     return CFStringCreateWithCString(cfallocator, "PhysicsFS",
                                      kCFStringEncodingASCII);
-} /* cfallocDesc */
+} /* cfallocCopyDesc */
 
 
 static void *cfallocMalloc(CFIndex allocSize, CFOptionFlags hint, void *info)
@@ -65,7 +65,7 @@
     /* set up a CFAllocator, so Carbon can use the physfs allocator, too. */
     CFAllocatorContext ctx;
     memset(&ctx, '\0', sizeof (ctx));
-    ctx.copyDescription = cfallocDesc;
+    ctx.copyDescription = cfallocCopyDesc;
     ctx.allocate = cfallocMalloc;
     ctx.reallocate = cfallocRealloc;
     ctx.deallocate = cfallocFree;