7z: do global initialization once without risking a race condition.
authorRyan C. Gordon <icculus@icculus.org>
Sun, 13 Aug 2017 22:53:38 -0400
changeset 1567 539b68269e9f
parent 1566 e96c747db3b8
child 1568 9e0c6ceefd41
7z: do global initialization once without risking a race condition.
src/physfs.c
src/physfs_archiver_7z.c
src/physfs_internal.h
--- a/src/physfs.c	Sun Aug 13 19:45:31 2017 -0400
+++ b/src/physfs.c	Sun Aug 13 22:53:38 2017 -0400
@@ -1143,6 +1143,7 @@
         REGISTER_STATIC_ARCHIVER(ZIP);
     #endif
     #if PHYSFS_SUPPORTS_7Z
+        SZIP_global_init();
         REGISTER_STATIC_ARCHIVER(7Z);
     #endif
     #if PHYSFS_SUPPORTS_GRP
--- a/src/physfs_archiver_7z.c	Sun Aug 13 19:45:31 2017 -0400
+++ b/src/physfs_archiver_7z.c	Sun Aug 13 22:53:38 2017 -0400
@@ -217,14 +217,6 @@
     SZIPinfo *info = NULL;
     SRes rc;
 
-    /* !!! FIXME-3.0: this is a race condition; we need a global init method that gets called when registering new archivers. */
-    static int generatedTable = 0;
-    if (!generatedTable)
-    {
-        generatedTable = 1;
-        CrcGenerateTable();
-    } /* if */
-
     BAIL_IF(forWriting, PHYSFS_ERR_READ_ONLY, NULL);
 
     info = (SZIPinfo *) allocator.Malloc(sizeof (SZIPinfo));
@@ -387,6 +379,19 @@
 } /* SZIP_stat */
 
 
+void SZIP_global_init(void)
+{
+    /* this just needs to calculate some things, so it only ever
+       has to run once, even after a deinit. */
+    static int generatedTable = 0;
+    if (!generatedTable)
+    {
+        generatedTable = 1;
+        CrcGenerateTable();
+    } /* if */
+} /* SZIP_global_init */
+
+
 const PHYSFS_Archiver __PHYSFS_Archiver_7Z =
 {
     CURRENT_PHYSFS_ARCHIVER_API_VERSION,
--- a/src/physfs_internal.h	Sun Aug 13 19:45:31 2017 -0400
+++ b/src/physfs_internal.h	Sun Aug 13 22:53:38 2017 -0400
@@ -193,6 +193,11 @@
 #define PHYSFS_SUPPORTS_VDF 1
 #endif
 
+#if PHYSFS_SUPPORTS_7Z
+/* 7zip support needs a global init function called at startup (no deinit). */
+extern void SZIP_global_init(void);
+#endif
+
 /* The latest supported PHYSFS_Io::version value. */
 #define CURRENT_PHYSFS_IO_API_VERSION 0