Skip to content

Commit

Permalink
Removed check that .zip files are less than 4 gigabytes.
Browse files Browse the repository at this point in the history
This would become a bogus check with zip64 support anyhow, but even here, if
 you have a .zip that's close to 4 gigabytes, and a self-extracting program
 prepended to it that pushes it over that limit, this test fails
 incorrectly.
  • Loading branch information
icculus committed Mar 13, 2012
1 parent a42ada1 commit 519046d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/archiver_zip.c
Expand Up @@ -425,8 +425,7 @@ static PHYSFS_sint64 zip_find_end_of_central_dir(PHYSFS_Io *io, PHYSFS_sint64 *l
int found = 0;

filelen = io->length(io);
BAIL_IF_MACRO(filelen == -1, NULL, 0); /* !!! FIXME: unlocalized string */
BAIL_IF_MACRO(filelen > 0xFFFFFFFF, "ZIP bigger than 4 gigs?!", 0);
BAIL_IF_MACRO(filelen == -1, NULL, 0);

/*
* Jump to the end of the file and start reading backwards.
Expand Down

0 comments on commit 519046d

Please sign in to comment.