Backport to stable-2.0: don't fsync read-only files.

icculus · Aug 22, 2013 · 87f4ed6 · 87f4ed6
1 parent 038b0fa
commit 87f4ed6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CREDITS.txt b/CREDITS.txt
@@ -109,6 +109,9 @@ Bug fixes:
 Bug fixes:
     Lauri Kasanen
 
+Bug fixes:
+    Andreas Karlsson
+
 Other stuff:
     Your name here! Patches go to icculus@icculus.org ...
 

diff --git a/platform/posix.c b/platform/posix.c
@@ -390,7 +390,8 @@ int __PHYSFS_platformEOF(void *opaque)
 int __PHYSFS_platformFlush(void *opaque)
 {
     int fd = *((int *) opaque);
-    BAIL_IF_MACRO(fsync(fd) == -1, strerror(errno), 0);
+    if ((fcntl(fd, F_GETFL) & O_ACCMODE) != O_RDONLY)
+        BAIL_IF_MACRO(fsync(fd) == -1, strerror(errno), 0);
     return(1);
 } /* __PHYSFS_platformFlush */